[OpenWrt-Devel] [PATCH] octeon: Replace backticks by $(...)

[Petr Štetiar]

Adrian Schmutzler <freifunk at adrianschmutzler.de> [2019-07-24 15:40:35]:

You've forget to provide commit description/message in all your patches,
usually answer to "Why do you need this changes?" or "Why are you proposing
this changes?"

> Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> ---
>  target/linux/octeon/base-files/lib/upgrade/platform.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/linux/octeon/base-files/lib/upgrade/platform.sh b/target/linux/octeon/base-files/lib/upgrade/platform.sh
> index 0e4ca37629..5d1a53a196 100755
> --- a/target/linux/octeon/base-files/lib/upgrade/platform.sh
> +++ b/target/linux/octeon/base-files/lib/upgrade/platform.sh
> @@ -85,8 +85,8 @@ platform_check_image() {
>  	er | \
>  	erlite)
>  		local tar_file="$1"
> -		local kernel_length=`(tar xf $tar_file sysupgrade-$board/kernel -O | wc -c) 2> /dev/null`
> -		local rootfs_length=`(tar xf $tar_file sysupgrade-$board/root -O | wc -c) 2> /dev/null`
> +		local kernel_length=$(tar xf $tar_file sysupgrade-$board/kernel -O | wc -c 2> /dev/null)
> +		local rootfs_length=$(tar xf $tar_file sysupgrade-$board/root -O | wc -c 2> /dev/null)

BTW, this looks more then backticks replacement, but also subshell removal.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel