[OpenWrt-Devel] [PATCH] ramips: add support to JS7628 development board
mail at adrianschmutzler.de
mail at adrianschmutzler.de
Mon Jul 22 06:16:06 EDT 2019
HI,
you mix spaces and tabs for indentation in DTS files. Those should have tab indentation.
Other comments below.
> -----Original Message-----
> From: Robinson Wu [mailto:wurobinson at qq.com]
> Sent: Sonntag, 21. Juli 2019 14:00
> To: openwrt-devel at lists.openwrt.org
> Cc: Robinson Wu <wurobinson at qq.com>
> Subject: [PATCH] ramips: add support to JS7628 development board
>
> This commit adds support for the ZhuoTK JS7628 development board, The
> device has the following specifications:
>
> - SOC:MT7628AN/NN
> - RAM:64/128/256 MB (DDR2)
> - FLASH:8/16/32 MB (SPI NOR)
> - Ethernet:3x 10/100 Mbps ethernet ports (MT7628 built-in switch)
> - WIFI:1x 2T2R 2.4 GHz Wi-Fi
> - LEDs:1x system status green LED, 1x wifi green LED,
> 3x ethernet green LED
> - Buttons:1x reset button, 2x user defined button
> - 1x microSD slot
> - 4x USB 2.0 port
> - 1x mini-usb debug UART
> - 1x DC jack for main power (DC 5V)
> - 1x TTL/RS232 UART
> - 1x TTL/RS485 UART
> - 13x GPIO header
> - 1x audio codec(wm8960)
>
> Installation via OpenWrt:
>
> The original firmware is OpenWrt, so both LuCI or sysupgrade can be used.
>
> Installation via U-boot web:
>
> 1. Power on board with reset button or key1 button pressed, release it
> after wifi led start blinking.
> 2. Setup static IP 192.168.1.123/4 on your PC.
> 3. Go to 192.168.1.8 in browser and upload "sysupgrade" image.
>
> Installation via U-boot tftp:
> 1. Connect to serial console at the mini usb, which has been connected to
> UART0
> on board (115200 8N1)
> 2. Setup static IP 192.168.1.123/4 on your PC.
> 3. Place openwrt-firmware.bin on your PC tftp server (192.168.1.123).
> 3. Connect one of LAN ports on board to your PC.
> 4. Start terminal software (e.g. screen /dev/ttyUSB0 115200) on PC.
> 5. Apply power to board.
> 6. Interrupt U-boot with keypress of "2".
> 7. At u-boot prompts:
> Warning!! Erase Linux in Flash then burn new one. Are you sure?(Y/N) Y
> Input device IP (192.168.1.8) ==:192.168.1.8
> Input server IP (192.168.1.123) ==:192.168.1.123
> Input Linux Kernel filename (root_uImage) ==:openwrt-firmware.bin 8.
> board will download file from tftp server, write it to flash and reboot.
>
> Other notes:
>
> 1. This board is available with three types of RAM with flash
> configuration. Chose one of the right "Target Profile" in
> "make menuconfig" as listed below:
>
> "ZhuoTK JS7628 8M flash/64M RAM"
> "ZhuoTK JS7628 16M flash/128M RAM"
> "ZhuoTK JS7628 32M flash/256M RAM"
>
> to fit the board you have.
>
> Vist www.zhuotk.com for further information.
>
> Signed-off-by: Robinson Wu <wurobinson at qq.com>
> ---
> target/linux/ramips/base-files/etc/board.d/01_leds | 6 ++
> .../linux/ramips/base-files/etc/board.d/02_network | 3 +
> .../ramips/dts/mt7628an_zhuotk_js7628-16m-128m.dts | 61
> +++++++++++++++++ .../ramips/dts/mt7628an_zhuotk_js7628-32m-
> 256m.dts | 61 +++++++++++++++++
> .../ramips/dts/mt7628an_zhuotk_js7628-8m-64m.dts | 61
> +++++++++++++++++
> .../linux/ramips/dts/mt7628an_zhuotk_js76x8.dtsi | 80
> ++++++++++++++++++++++
> target/linux/ramips/image/mt76x8.mk | 33 +++++++++
> 7 files changed, 305 insertions(+)
> create mode 100644 target/linux/ramips/dts/mt7628an_zhuotk_js7628-
> 16m-128m.dts
> create mode 100644 target/linux/ramips/dts/mt7628an_zhuotk_js7628-
> 32m-256m.dts
> create mode 100644 target/linux/ramips/dts/mt7628an_zhuotk_js7628-8m-
> 64m.dts
> create mode 100644 target/linux/ramips/dts/mt7628an_zhuotk_js76x8.dtsi
>
> diff --git a/target/linux/ramips/base-files/etc/board.d/01_leds
> b/target/linux/ramips/base-files/etc/board.d/01_leds
> index 57f0939..0d876c4 100755
> --- a/target/linux/ramips/base-files/etc/board.d/01_leds
> +++ b/target/linux/ramips/base-files/etc/board.d/01_leds
> @@ -458,6 +458,12 @@ zbtlink,zbt-we1226)
> ucidef_set_led_switch "lan2" "LAN2" "$boardname:green:lan2"
> "switch0" "0x02"
> ucidef_set_led_switch "wan" "WAN" "$boardname:green:wan"
> "switch0" "0x10"
> ;;
> +zhuotk,js7628-8m-64m|\
> +zhuotk,js7628-16m-128m|\
> +zhuotk,js7628-32m-256m)
> + ucidef_set_led_timer "system" "system" "js76x8:green:system"
> "1000" "1000"
> + set_wifi_led "js76x8:green:wifi"
> + ;;
> zorlik,zl5900v2)
> ucidef_set_led_netdev "lan" "lan" "$boardname:green:lan" eth0
> ;;
> diff --git a/target/linux/ramips/base-files/etc/board.d/02_network
> b/target/linux/ramips/base-files/etc/board.d/02_network
> index a2b7d1c..f438b46 100755
> --- a/target/linux/ramips/base-files/etc/board.d/02_network
> +++ b/target/linux/ramips/base-files/etc/board.d/02_network
> @@ -103,6 +103,9 @@ ramips_setup_interfaces()
> zbtlink,zbt-wg3526-16m|\
> zbtlink,zbt-wg3526-32m|\
> zbtlink,zbt-wr8305rt|\
> + zhuotk,js7628-8m-64m|\
> + zhuotk,js7628-16m-128m|\
> + zhuotk,js7628-32m-256m|\
> zyxel,keenetic|\
> zyxel,keenetic-omni)
> ucidef_add_switch "switch0" \
> diff --git a/target/linux/ramips/dts/mt7628an_zhuotk_js7628-16m-128m.dts
> b/target/linux/ramips/dts/mt7628an_zhuotk_js7628-16m-128m.dts
> new file mode 100644
> index 0000000..397cd01
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7628an_zhuotk_js7628-16m-128m.dts
> @@ -0,0 +1,61 @@
> +/dts-v1/;
> +
> +
> +#include "mt7628an_zhuotk_js76x8.dtsi"
> +
> +/ {
> + compatible = "zhuotk,js7628-16m-128m", "zhuotk,js76x8",
> "mediatek,mt7628an-soc";
> + model = "ZhuoTK JS7628 (16M flash/128M RAM)"; };
> +
> +&spi0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi_pins>, <&spi_cs1_pins>;
> +
> + m25p80 at 0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + m25p,chunked-io = <32>;
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition at 0 {
> + label = "u-boot";
> + reg = <0x0 0x30000>;
> + read-only;
> + };
> +
> + partition at 30000 {
> + label = "u-boot-env";
> + reg = <0x30000 0x10000>;
> + read-only;
> + };
> +
> + factory: partition at 40000 {
> + label = "factory";
> + reg = <0x40000 0x10000>;
> + read-only;
> + };
> +
> + partition at 50000 {
> + compatible = "denx,uimage";
> + label = "firmware";
> + reg = <0x50000 0xfb0000>;
> + };
> + };
> + };
> +
> + spidev at 1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "linux,spidev";
> + reg = <1>;
> + spi-max-frequency = <40000000>;
> + };
> +};
> diff --git a/target/linux/ramips/dts/mt7628an_zhuotk_js7628-32m-256m.dts
> b/target/linux/ramips/dts/mt7628an_zhuotk_js7628-32m-256m.dts
> new file mode 100644
> index 0000000..10970ea
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7628an_zhuotk_js7628-32m-256m.dts
> @@ -0,0 +1,61 @@
> +/dts-v1/;
> +
> +
> +#include "mt7628an_zhuotk_js76x8.dtsi"
> +
> +/ {
> + compatible = "zhuotk,js7628-32m-256m", "zhuotk,js76x8",
> "mediatek,mt7628an-soc";
> + model = "ZhuoTK JS7628 (32M flash/256M RAM)"; };
> +
> +&spi0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi_pins>, <&spi_cs1_pins>;
> +
> + m25p80 at 0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + m25p,chunked-io = <32>;
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition at 0 {
> + label = "u-boot";
> + reg = <0x0 0x30000>;
> + read-only;
> + };
> +
> + partition at 30000 {
> + label = "u-boot-env";
> + reg = <0x30000 0x10000>;
> + read-only;
> + };
> +
> + factory: partition at 40000 {
> + label = "factory";
> + reg = <0x40000 0x10000>;
> + read-only;
> + };
> +
> + partition at 50000 {
> + compatible = "denx,uimage";
> + label = "firmware";
> + reg = <0x50000 0x1fb0000>;
> + };
> + };
> + };
> +
> + spidev at 1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "linux,spidev";
> + reg = <1>;
> + spi-max-frequency = <40000000>;
> + };
> +};
> diff --git a/target/linux/ramips/dts/mt7628an_zhuotk_js7628-8m-64m.dts
> b/target/linux/ramips/dts/mt7628an_zhuotk_js7628-8m-64m.dts
> new file mode 100644
> index 0000000..66db75f
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7628an_zhuotk_js7628-8m-64m.dts
> @@ -0,0 +1,61 @@
> +/dts-v1/;
> +
> +
> +#include "mt7628an_zhuotk_js76x8.dtsi"
> +
> +/ {
> + compatible = "zhuotk,js7628-8m-64m", "zhuotk,js76x8",
> "mediatek,mt7628an-soc";
> + model = "ZhuoTK JS7628 (8M flash/64M RAM)"; };
> +
> +&spi0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi_pins>, <&spi_cs1_pins>;
> +
> + m25p80 at 0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + m25p,chunked-io = <32>;
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition at 0 {
> + label = "u-boot";
> + reg = <0x0 0x30000>;
> + read-only;
> + };
> +
> + partition at 30000 {
> + label = "u-boot-env";
> + reg = <0x30000 0x10000>;
> + read-only;
> + };
> +
> + factory: partition at 40000 {
> + label = "factory";
> + reg = <0x40000 0x10000>;
> + read-only;
> + };
> +
> + partition at 50000 {
> + compatible = "denx,uimage";
> + label = "firmware";
> + reg = <0x50000 0x7b0000>;
> + };
> + };
> + };
> +
> + spidev at 1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "linux,spidev";
> + reg = <1>;
> + spi-max-frequency = <40000000>;
> + };
> +};
> diff --git a/target/linux/ramips/dts/mt7628an_zhuotk_js76x8.dtsi
> b/target/linux/ramips/dts/mt7628an_zhuotk_js76x8.dtsi
> new file mode 100644
> index 0000000..0dcfd10
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7628an_zhuotk_js76x8.dtsi
> @@ -0,0 +1,80 @@
> +#include "mt7628an.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> + compatible = "zhuotk,js76x8", "mediatek,mt7628an-soc";
> +
> + aliases {
> + led-boot = &led_system;
> + led-failsafe = &led_system;
> + led-running = &led_system;
> + led-upgrade = &led_system;
> + };
> +
> + chosen {
> + bootargs = "console=ttyS0,115200";
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + led_system: system {
> + label = "js76x8:green:system";
> + gpios = <&gpio1 5 GPIO_ACTIVE_LOW>;
> + };
> +
> + wifi {
> + label = "js76x8:green:wifi";
> + gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> + keys {
> + compatible = "gpio-keys-polled";
> + poll-interval = <20>;
> +
> + reset {
> + label = "reset";
> + gpios = <&gpio1 12 GPIO_ACTIVE_HIGH>;
> + linux,code = <KEY_RESTART>;
> + };
> + };
> +};
> +
> +
> +&pinctrl {
> + state_default: pinctrl0 {
> + gpio {
> + ralink,group = "gpio","wdt","pwm0","pwm1","spis",
> + "refclk";
> + ralink,function = "gpio";
> + };
> + };
> +};
> +
> +&i2c {
> + status = "okay";
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> +
> +&uart2 {
> + status = "okay";
> +};
> +
> +ðernet {
> + mtd-mac-address = <&factory 0x28>;
Do these devices typically have a label with their MAC addresses printed on it? If yes, does the printed MAC address correspond to ethernet here?
> +};
> +
> +&sdhci {
> + status = "okay";
> + mediatek,cd-low;
> +};
> +
> +&wmac {
> + status = "okay";
> +};
> diff --git a/target/linux/ramips/image/mt76x8.mk
> b/target/linux/ramips/image/mt76x8.mk
> index fae9fb0..f97d78a 100644
> --- a/target/linux/ramips/image/mt76x8.mk
> +++ b/target/linux/ramips/image/mt76x8.mk
> @@ -549,6 +549,39 @@ define Device/zbtlink_zbt-we1226 endef
> TARGET_DEVICES += zbtlink_zbt-we1226
>
> +define Device/zhuotk_js7628-8m-64m
> + MTK_SOC := mt7628an
> + IMAGE_SIZE := $(ralink_default_fw_size_8M)
Please specify the IMAGE_SIZE in kiB, e.g. 7872k (also below).
> + DEVICE_VENDOR := ZhuoTK
> + DEVICE_MODEL := JS7628
> + DEVICE_VARIANT := 8M flash/64M RAM
> + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci
> + SUPPORTED_DEVICES += js7628-8m-64m js7688-8m-64m ztk7628p-8m-64m
What do you want to achieve with this line?
Best
Adrian Schmutzler
> +endef TARGET_DEVICES += zhuotk_js7628-8m-64m
> +
> +define Device/zhuotk_js7628-16m-128m
> + MTK_SOC := mt7628an
> + IMAGE_SIZE := $(ralink_default_fw_size_16M)
> + DEVICE_VENDOR := ZhuoTK
> + DEVICE_MODEL := JS7628
> + DEVICE_VARIANT := 16M flash/128M RAM
> + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci
> + SUPPORTED_DEVICES += js7628-16m-128m js7688-16m-128m ztk7628p-
> 16m-64m
> +endef TARGET_DEVICES += zhuotk_js7628-16m-128m
> +
> +define Device/zhuotk_js7628-32m-256m
> + MTK_SOC := mt7628an
> + IMAGE_SIZE := $(ralink_default_fw_size_32M)
> + DEVICE_VENDOR := ZhuoTK
> + DEVICE_MODEL := JS7628
> + DEVICE_VARIANT := 32M flash/256M RAM
> + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci
> + SUPPORTED_DEVICES += js7628-32m-256 js7688-32m-256m ztk7628p-32m-
> 64m
> +endef TARGET_DEVICES += zhuotk_js7628-32m-256m
> +
> define Device/zyxel_keenetic-extra-ii
> MTK_SOC := mt7628an
> IMAGE_SIZE := 14912k
> --
> 2.7.4
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190722/9ed76725/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list