[OpenWrt-Devel] "mac80211: Update to version 5.2-rc7" breaks batman-adv

[Jeff Kletsky]

On 7/21/19 4:16 PM, Jeff Kletsky wrote:
>
> git bisect suggests
>
> commit 0b2c42ced2 (HEAD, refs/bisect/bad)
>
>     mac80211: Update to version 5.2-rc7
>
> as the problem behind the failure to compile batman-adv on July 21, 
> 2019 and perhaps prior
>
> See, for example 
> http://downloads.openwrt.org/snapshots/faillogs/mips_24kc/routing/batman-adv/compile.txt
>
> /builder/shared-workdir/build/sdk/build_dir/target-mips_24kc_musl/linux-ath79_generic/batman-adv-2019.2/net/batman-adv/netlink.c:1347:4: error: 'const struct backport_genl_ops' has no member named 'policy'
>     .policy = batadv_netlink_policy,
>      ^~~~~~
>
>
> Same problem observed locally on ath79 and on ipq40xx
>
> Nothing obvious in the patch itself, but building at d616b2c906 
> resolves the issue for both ipq40xx and ath79 builds
>
>

Looks like the likely (upstream) event that triggered this was

(Linux) commit 3b0f31f2b8c9
Author: Johannes Berg <johannes.berg at intel.com>
Date:   Thu Mar 21 22:51:02 2019 +0100

     genetlink: make policy common to family


which moves .policy off where "current" batman-adv is expecting it.

The backport tar ball does contain backport-include/net/genetlink.h 
which seems to be picked up inappropriately for batman-adv, or there is 
a patch missing for batman-adv (commit 3b0f31f2b8c9 does modify it), or ...

I haven't quite figured out how the backports work, so don't yet know 
the root cause and "best" solution.


Jeff


See also 
https://forum.openwrt.org/t/batman-adv-build-failure-master-2019-07-21/41205

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190721/9f1720f9/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel