[OpenWrt-Devel] [PATCH v2] ramips: add support for Edimax RG21S

[mail at adrianschmutzler.de]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Birger Koblitz
> Sent: Samstag, 20. Juli 2019 12:49
> To: openwrt-devel at lists.openwrt.org
> Subject: [OpenWrt-Devel] [PATCH v2] ramips: add support for Edimax RG21S
> 
> ramips: add Edimax RG21S
> 

Some comments:
- You can remove the memory node since mt7621 has auto-detection now.
- Please specify IMAGE_SIZE in kiB since the ralink...16M variable currently not matches your partition size

> +		wps {
> +                        label = "wps";
> +                        gpios = <&gpio0 18 GPIO_ACTIVE_LOW>;
> +                        linux,code = <KEY_RESTART>;
> +                };
> +	};

Indentation is broken there for some lines.

Can you report which of the MAC addresses matches the one on the devices label/sticker/cover/box?

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190720/1880972f/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel