[OpenWrt-Devel] [PATCH] generic: ar8216: ar8327: kill warnings

Chuanhong Guo gch981213 at gmail.com
Thu Jan 10 12:22:42 EST 2019


This fixed warnings caused by returning value in a void function

Signed-off-by: Chuanhong Guo <gch981213 at gmail.com>
---
 target/linux/generic/files/drivers/net/phy/ar8327.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/linux/generic/files/drivers/net/phy/ar8327.c b/target/linux/generic/files/drivers/net/phy/ar8327.c
index 13e911bbc3..5af6aaf6f2 100644
--- a/target/linux/generic/files/drivers/net/phy/ar8327.c
+++ b/target/linux/generic/files/drivers/net/phy/ar8327.c
@@ -139,7 +139,7 @@ ar8327_phy_rgmii_set(struct ar8xxx_priv *priv, struct phy_device *phydev)
 
 	if (!of_property_read_bool(np, "qca,phy-rgmii-en")) {
 		pr_err("ar8327: qca,phy-rgmii-en is not specified\n");
-		return -EINVAL;
+		return;
 	}
 	ar8xxx_phy_dbg_read(priv, phyaddr,
 				AR8327_PHY_MODE_SEL, &phy_val);
@@ -150,7 +150,7 @@ ar8327_phy_rgmii_set(struct ar8xxx_priv *priv, struct phy_device *phydev)
 	/* set rgmii tx clock delay if needed */
 	if (!of_property_read_bool(np, "qca,txclk-delay-en")) {
 		pr_err("ar8327: qca,txclk-delay-en is not specified\n");
-		return -EINVAL;
+		return;
 	}
 	ar8xxx_phy_dbg_read(priv, phyaddr,
 				AR8327_PHY_SYS_CTRL, &phy_val);
@@ -161,7 +161,7 @@ ar8327_phy_rgmii_set(struct ar8xxx_priv *priv, struct phy_device *phydev)
 	/* set rgmii rx clock delay if needed */
 	if (!of_property_read_bool(np, "qca,rxclk-delay-en")) {
 		pr_err("ar8327: qca,rxclk-delay-en is not specified\n");
-		return -EINVAL;
+		return;
 	}
 	ar8xxx_phy_dbg_read(priv, phyaddr,
 				AR8327_PHY_TEST_CTRL, &phy_val);
-- 
2.20.1


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list