[OpenWrt-Devel] [PATCH] dnsmasq: prefer localuse over resolvfile guesswork

[Yousong Zhou]

On Fri, 22 Feb 2019 at 20:13, Paul Oranje <por at oranjevos.nl> wrote:
>
>
> > Op 22 feb. 2019, om 02:54 heeft Yousong Zhou <yszhou4tech at gmail.com> het volgende geschreven:
> >
> > On Thu, 21 Feb 2019 at 22:14, Paul Oranje <por at oranjevos.nl> wrote:
> >>
> >>
> >>
> >>> Op 21 feb. 2019, om 04:52 heeft Yousong Zhou <yszhou4tech at gmail.com> het volgende geschreven:
> >>>
> >>> This makes it clear that localuse when explicitly specified in the
> >>> config will have its final say on whether or not the initscript should
> >>> touch /etc/resolv.conf, no matter whatever the result of previous
> >>> guesswork would be
> >>>
> >>> Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> >
> > <snipped>
> >
> >>
> >> Tested this patch (8f16fba501) and the previous patch (ec2a2a2aea) on top of 18.06.2.
> >>
> >> The patches apply cleanly and the patched file works as expected:
> >>
> >> - localuse=1 and noresolv and resolvfile not set => dnsmasq writes resolv.conf
> >> - localuse and noresolv and resolvfile not set => dnsmasq writes resolv.conf
> >> - localuse=0 and noresolv and resolvfile not set => dnsmasq leaves resolv.conf untouched
> >> - localuse not set and noresolv=1 and resolvfile='/tmp/resolv.conf.auto' => dnsmasq leaves resolv.conf untouched.
> >>
> >> The latter two scenario's work well with Unbound (where dnsmasq handles DHCP and DNS of lan host names).
> >> Thanks.
> >>
> >> Tested-by: Paul Oranje <por at oranjevos.nl>
> >
> > Thanks ;)
> Can these patches also be applied against the openwrt-18.06 branch or must they be submitted separately for that end ?

I just did the cherry-pick and sent the result to the devel list.
Skimmed through past history of release branch, I think this acked-by
process is needed as these patches are with new options for feature
changes, not just fixes.

Regards,
                yousong

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel