[OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

Paul Spooren mail at aparcar.org
Thu Aug 22 15:07:02 EDT 2019


On 22.08.19 00:11, John Crispin wrote:
>
> On 22/08/2019 08:47, Paul Spooren wrote:
>> Hi John,
>>> This commit adds the Generic subtarget resulting in consistent naming. 
>>
>> and
>>
>>> already uses `x/generic/` as subfolder as if the subtarget would exist. 
>>
>> I'm very much in favor of consistent names[0][1][2] as it reduces the 
>> hassle when trying automate things, like building images via an API[3].
>>
>> Is the subtarget causing any harm except for eight additional 
>> characters per filename?
>>
>> Paul
>>
>> [0]: https://github.com/openwrt/openwrt/pull/2330
>> [1]: https://github.com/openwrt/openwrt/pull/2334
>> [2]: https://github.com/openwrt/openwrt/pull/2326
>> [3]: https://github.com/aparcar/attendedsysupgrade-server
>>
> dont really care, just wondering why

If you don't mind please merge it, I think it's the last target without 
a defined subtarget.

Paul



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list