[OpenWrt-Devel] [PATCH v3 3/5] ath79: add support for Netgear WNR2000 v3

[Adrian Schmutzler]

Hi, comments below, too:

> diff --git a/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom b/target/linux/ath79/base-
> files/etc/hotplug.d/firmware/10-ath9k-eeprom
> index ec597dd1d4..747c1aab58 100644
> --- a/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom
> +++ b/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom
> @@ -165,6 +165,7 @@ case "$FIRMWARE" in
>  	winchannel,wb2000)
>  		ath9k_eeprom_extract "art" 20480 1088
>  		;;
> +	netgear,wnr2000-v3|\
>  	netgear,wnr612-v2|\
>  	on,n150r|\
>  	pcs,cap324|\

You are using mtd-cal-data in DTS for this device. Does this work? Then you should be able to remove the entries in 10-ath9k-eeprom. Otherwise, remove mtd-cal-data. Based on the result, you may want to change the other devices accordingly.

> +&pcie {
> +	status = "okay";
> +
> +	ath9k: wifi at 0,0 {
> +		compatible = "pci168c,002e";
> +		reg = <0x0000 0 0 0 0>;
> +		mtd-mac-address = <&art 0x0>;
> +		mtd-mac-address-increment = <1>;
> +		mtd-cal-data = <&art 0x1000>;

Despite comments from above, we have the same situation regarding MAC address here. Is the MAC address read via cal-data already? Then act as described in the previous patch annotation.

> +	};
> +};
> +
> +&uart {
> +	status = "okay";
> +};
> +
> +&gpio {
> +        status = "okay";
> +};

Leading spaces here. Change to tabs. And maybe check all your files, as I just found this by accident and did not look everywhere ...

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190812/e5b3d61f/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel