[OpenWrt-Devel] [PATCH] [RFC] kernel: disable EAP local hack when using group_fwd_mask

[Etienne Champetier]

Hi Petr,

Le jeu. 1 août 2019 à 11:39, Petr Štetiar <ynezz at true.cz> a écrit :
>
> Etienne Champetier <champetier.etienne at gmail.com> [2019-08-01 07:23:18]:
>
> > If the fix was to workaround a client bug we might want to keep it,
>
> Actually we don't know if it wasnt fixed already upstream as Rafał suggested
> in his old removal patch.
>
> > else maybe we could rework it and add a warn_once if this hack prevent
> > a EAP frame from being forwarded
>
> This warn_once would have probably saved some time already.
>
> > 'disable-eap-local-hack' to enable/disable this hack, what do you
> > prefer ?
>
> I would prefer to remove this patch for 4.19 kernel to find out if it's still
> needed.

you mean all versions in master (4.19/4.14/4.9) or really only 4.19 ?

> And if it's needed, then it would make sense to discuss this use case
> with upstream and make it official feature.

I have a small tool/OpenWrt package
(https://github.com/openwrt/packages/blob/master/net/phantap/Makefile)
that I'm presenting at DEF CON in a week, and would really love to
have a way to disable this hack,
so I don't have to tell people that want to test it that they have to
rebuild OpenWrt.
So I'm willing to work on any small patch that workaround my issue and
seems reasonable to everyone in a short time-frame ;)

>
> Let's wait for Felix's input as well.

I'll also try to dig some more in the old repo & bug tracker to see if
there is more info than in the patch & email

Etienne

>
> -- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel