[OpenWrt-Devel] [PATCH 1/2] scripts/qemustart: no-network by default and enable with -n

[Hans Dedecker]

On Thu, Apr 25, 2019 at 5:40 PM Yousong Zhou <yszhou4tech at gmail.com> wrote:
>
> On Thu, 25 Apr 2019 at 23:05, Hans Dedecker <dedeckeh at gmail.com> wrote:
> >
> > Hi Yousong,
> >
> > On Thu, Apr 25, 2019 at 4:29 PM Yousong Zhou <yszhou4tech at gmail.com> wrote:
> > >
> > > Before this change, we have no way to have network on as both bash and
> > > zsh have zero exit status for "[ -n ]" and "[ -z ]"
> > >
> > > By running qemu without network by default we make common usage of and
> > > first encounter with qemustart script more comfortable.  With networking
> > > only two characters argument away.
> > >
> > > Cc: Petr Štetiar <ynezz at true.cz>
> > > Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
> > > ---
> > >  scripts/qemustart | 12 +++++++-----
> > >  1 file changed, 7 insertions(+), 5 deletions(-)
>
> ...
>
> > >
> > I pushed a patch
> > (https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=9424b6f998917e2926c0b7afb8d7a968590da335)
> > yesterday which fixes the [ -n ] and [ -z ] issues
> >
> > Hans
>
> I missed that one ;)  But I would still like to propose that we make
> "no network" the default.  I assume that would be easier to set up and
> works for most cases.  What do you think?
For ease of use that's fine for me

Hans
>
>                 yousong

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel