[OpenWrt-Devel] [PATCH] ar71xx: add support for GL.iNet GL-X1200

[Petr Štetiar]

Guilin.Wang <guilin.wang at gl-inet.com> [2019-04-11 17:18:12]:

Hi,

> I want to submit it to ar71xx first, and I will submit it to ath79 later.

tl;dr version:

please don't waste your (and our time) with ar71xx anymore. BTW it was ath79
first and ar71xx possibly later, but this period is already over. At least for
me ar71xx is currently in 'fixes only' mode.

Longer version:

Even if you've provided ath79 support first I would simply hesitate to include
ar71xx support for this device as it has simply non trivial amount of changes
(the non-written rule it was agreed upon). Your changeset has following numstats:

 12 files changed, 218 insertions(+)

Please take a look at the recent commits to ar71xx, it's pretty much 'fixes only' mode already:

 93d23aced ar71xx: Correct MAC address for WAN interface of Archer C7 v5
  1 file changed, 4 insertions(+)

 9aa8f87d2 ar71xx: Add "info" partition for TP-Link Archer C7 v5
  1 file changed, 1 insertion(+), 1 deletion(-)

 31ea08a64 ar71xx: ag71xx: Fix broken networking on some devices (FS#2177)
  1 file changed, 3 insertions(+), 2 deletions(-)

 0f8cdc28a ar71xx: Add support for Ubiquity Bullet M (XW)
  8 files changed, 18 insertions(+)

 6009b3fd5 ar71xx: ubnt-m-xw: Fix factory image flashing using TFTP recovery
  1 file changed, 11 insertions(+), 2 deletions(-)

 99f6f2c0b ar71xx: Add support for TP-Link CPE210 v3
  7 files changed, 29 insertions(+), 2 deletions(-)

 a2a972b2c ar71xx: Use dynamic partitions for TP-Link CPE210 v2
  1 file changed, 3 insertions(+), 1 deletion(-)

 0a67e84ba ar71xx: ens202ext: Fix whitespace issues
  1 file changed, 4 insertions(+), 4 deletions(-)

 d260813d0 ar71xx: ens202ext: Fix VLAN switch
  1 file changed, 5 insertions(+), 1 deletion(-)

 e1444ab59 ar71xx: add support for MikroTik RouterBOARD 922UAGS-5HPacD
  6 files changed, 87 insertions(+), 29 deletions(-)

 0304e76cd kernel: bump 4.14 to 4.14.107
  2 files changed, 5 insertions(+), 5 deletions(-)

 5ac974f21 ar71xx: Add support for Mikrotik RB SXT 2nD r3
  6 files changed, 9 insertions(+), 1 deletion(-)

 34113999e ar71xx: Remove ath10k packages from archer-c7-v1 (fixes FS#1743)
  1 file changed, 1 insertion(+), 1 deletion(-)

 26f7cf8ac ar71xx: Speed up mtd extraction in ar71xx.sh
  1 file changed, 2 insertions(+), 2 deletions(-)

 51fb186cb ar71xx: Speed up caldata/eeprom handling
  2 files changed, 6 insertions(+), 6 deletions(-)

 fe591f2fe ar71xx: enable QCA955x SGMII fixup on Rambutan
  1 file changed, 2 insertions(+)

 d3506d1bc ar71xx: ag71xx: fix compile error when enabling debug
  1 file changed, 5 insertions(+), 6 deletions(-)

 e65f935de ar71xx: Change led trigger from usbdev to usbport
  1 file changed, 46 insertions(+), 46 deletions(-)

 53c46b504 ar71xx: GL.iNet AR300M family: correct LED definitions
  2 files changed, 2 insertions(+), 8 deletions(-)

 319c5d7c4 ar71xx: Fix 5 GHz MAC address for Archer C60 v2
  1 file changed, 6 insertions(+), 1 deletion(-)

 78277ec16 ar71xx: fix TL-MR3220-v2 switch port order
  1 file changed, 1 insertion(+), 1 deletion(-)

 341311f319b18b74d1d112709830979ceab11f67 ar71xx: fix TL-WR741ND-v4 switch port order
  1 file changed, 5 insertions(+), 1 deletion(-)

 8c9f255ce56a43ecd49c80688052a02029c4fa52 ar71xx: add rssileds for xw devices
    1 file changed, 1 insertion(+)

and just following commits have introduced new devices, so I'm adding reason why
it was included as well:

 0f8cdc28a ar71xx: Add support for Ubiquity Bullet M (XW)
  8 files changed, 18 insertions(+)

  added by me, it's already in ath79, patch was simple enough and I need this
  for ar71xx/ath79 testing

 99f6f2c0b ar71xx: Add support for TP-Link CPE210 v3
  7 files changed, 29 insertions(+), 2 deletions(-)

  commited by me, because this PR was lingering on the GitHub since 13th August
  2018, they worked really hard to make this happen(ath79, dynamic partitions
  etc) and the changes to ar71xx tree were really small, easy to review, very
  well tested so I've decided to give it a go.

 e1444ab59 ar71xx: add support for MikroTik RouterBOARD 922UAGS-5HPacD
  6 files changed, 87 insertions(+), 29 deletions(-)

  added by xback, can't comment on this one

 5ac974f21 ar71xx: Add support for Mikrotik RB SXT 2nD r3
  6 files changed, 9 insertions(+), 1 deletion(-)

  commited by me, because this PR was lingering on the GitHub since 18th
  October 2018, was simple enough and the user worked hard to get it in

So please stop sending ar71xx patches which are adding support for new devices,
ar71xx is really in 'fixes only' mode and you're wasting your time.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel