[OpenWrt-Devel] [PATCH 1/2] ar71xx: flag FritzBox 4020 buttons as active low

David Bauer mail at david-bauer.net
Tue Sep 11 11:04:16 EDT 2018


Buttons of AVM FritzBox 4020 are incorrectly flagged as active high.

This was an oversight as RFKill button was working as expected even
with incorrectly flagged GPIO.

Signed-off-by: David Bauer <mail at david-bauer.net>
---

This commit should also be applied to the openwrt-18.06 branch as the
issue is also present there.

 target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c
index ed7f9a8b3e..c00cf681b2 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c
@@ -169,7 +169,7 @@ static struct gpio_keys_button fritz4020_gpio_keys[] __initdata = {
 		.code			= KEY_RFKILL,
 		.debounce_interval	= FRITZ4020_KEYS_DEBOUNCE_INTERVAL,
 		.gpio			= FRITZ4020_GPIO_BTN_WLAN,
-		.active_low		= 0,
+		.active_low		= 1,
 	},
 	{
 		.desc			= "WPS button",
@@ -177,7 +177,7 @@ static struct gpio_keys_button fritz4020_gpio_keys[] __initdata = {
 		.code			= KEY_WPS_BUTTON,
 		.debounce_interval	= FRITZ4020_KEYS_DEBOUNCE_INTERVAL,
 		.gpio			= FRITZ4020_GPIO_BTN_WPS,
-		.active_low		= 0,
+		.active_low		= 1,
 	},
 };
 
-- 
2.18.0


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list