[OpenWrt-Devel] [PATCH 1/2] ramips: Use generic board detect for GnuBee devices

[Rosen Penev]

On Fri, May 25, 2018 at 3:23 AM, Mathias Kresin <dev at kresin.me> wrote:
> 2018-05-25 6:43 GMT+03:00 Rosen Penev <rosenp at gmail.com>:
>> This is a port of an old commit from mkresin's tree:
>>
>> 09260cdf3e9332978c2a474a58e93a6f2b55f4a8
>>
>> This has the potential to break sysupgrade but it should be fine as
>> there is no stable release of LEDE or OpenWrt that support these devices.
>>
>> Signed-off-by: Rosen Penev <rosenp at gmail.com>
>> ---
>>  target/linux/ramips/base-files/etc/board.d/01_leds     | 4 ++--
>>  target/linux/ramips/base-files/etc/board.d/02_network  | 4 ++--
>>  target/linux/ramips/base-files/etc/diag.sh             | 4 ++--
>>  target/linux/ramips/base-files/lib/ramips.sh           | 3 ---
>>  target/linux/ramips/base-files/lib/upgrade/platform.sh | 4 ++--
>>  target/linux/ramips/dts/GB-PC1.dts                     | 2 +-
>>  target/linux/ramips/dts/GB-PC2.dts                     | 2 +-
>>  target/linux/ramips/image/mt7621.mk                    | 8 ++++----
>>  8 files changed, 14 insertions(+), 17 deletions(-)
>>
>> diff --git a/target/linux/ramips/base-files/etc/board.d/01_leds b/target/linux/ramips/base-files/etc/board.d/01_leds
>> index 88e4c2b7fe..79f2cc2b87 100755
>> --- a/target/linux/ramips/base-files/etc/board.d/01_leds
>> +++ b/target/linux/ramips/base-files/etc/board.d/01_leds
>> @@ -196,8 +196,8 @@ fonera20n)
>>         set_usb_led "$boardname:orange:usb"
>>         set_wifi_led "$boardname:orange:wifi"
>>         ;;
>> -gb-pc1|\
>> -gnubee,gb-pc2)
>> +gnubee,pc1|\
>> +gnubee,pc2)
>>         ucidef_set_led_switch "lan1" "lan1" "$boardname:green:lan1" "switch0" "0x01"
>>         ucidef_set_led_switch "lan2" "lan2" "$boardname:green:lan2" "switch0" "0x10"
>>         ;;
>
> This will not work. You need to rename the LEDs from gb-pc[1|2]:green:
> to pc[1|2]:green: in the devicetree source files.
>
> But instead of doing so, please drop the compatible changes, and use
> "gnubee,gb-pc1". I don't see much gain in changing them.
It's a bit clearer but sure, I'll drop.
>
> Mathias

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
http://lists.infradead.org/mailman/listinfo/openwrt-devel