[OpenWrt-Devel] Latest OpenWRT on Gemini v4.14

[Linus Walleij]

On Tue, Mar 13, 2018 at 10:52 PM, Hauke Mehrtens <hauke at hauke-m.de> wrote:

> We updated to GCC 7 as default compiler now, so this problems should be
> solved.

Great! Thanks.

> I saw this dns313-header.c tool, this should better be added to
> tools/firmware-utils/src/ which already provides tools for other
> firmware header formats.
>
> This "Copyright (C) 2009-2018 OpenWrt.org" is not really valid as
> OpenWrt.org is no legal entity, please just leave it there if it already
> exists and add your own if needed.
>
> You changed the indention for the files in base-files form tabs to
> spaces, please use tabs.

OK I will fix this.

> Could you send this for review as a full patch to the mailling list, or
> if it is too big remove the patches you backported from the mainline
> kernel for the review part, I trust the upstream kernel developers that
> they reviewed this better than I can do it.

Yeah I will try to split it up in some reasonable way.

Yours,
Linus Walleij
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel