[OpenWrt-Devel] [PATCH v2] build: download code from github using archive API
Yousong Zhou
yszhou4tech at gmail.com
Fri Jun 29 01:59:22 EDT 2018
On Fri, 29 Jun 2018 at 13:16, Jo-Philipp Wich <jo at mein.io> wrote:
>
> Hi Yousong,
>
> this change seems to introduce serious runtime regressions, see
> https://bugs.openwrt.org/index.php?do=details&task_id=1621
>
> It seems to be like that script does things even if the tarballs are
> already existing locally.
>
> On a slightly related note, I find the name to be too generic. It
> implies that it handles all kinds of download tasks but in the end it is
> only a Github archive wrapper. Maybe you should rename it to github.py
> or similar.
>
> ~ Jo
Looks like it's caused by the excessive python script call. This is
indeed unexpected. I just pushed a commit to disable it altogether
for now. Sorry for the inconvenience ;(
yousong
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list