[OpenWrt-Devel] [PATCH 3/3] package: ignore some new errors introduced by GCC 8

[Syrone Wong]

Hi,

I definitely agree we should fix errors, this commit is to bypass
warnings and see if other important components are working well, e.g.
no kernel panic,
busybox is functional, etc. Others can be fixed as the follow-up. It
makes sense to ignore this testing commit.


Best Regards,
Syrone Wong


On Fri, Jun 22, 2018 at 3:15 AM, Mathias Kresin <dev at kresin.me> wrote:
> 21.06.2018 17:08, wong.syrone at gmail.com:
>
>> From: Syrone Wong <wong.syrone at gmail.com>
>>
>> Signed-off-by: Syrone Wong <wong.syrone at gmail.com>
>> ---
>>   package/network/config/firewall/Makefile | 2 +-
>>   package/system/procd/Makefile            | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/network/config/firewall/Makefile
>> b/package/network/config/firewall/Makefile
>> index 01fea237f3..43673cf777 100644
>> --- a/package/network/config/firewall/Makefile
>> +++ b/package/network/config/firewall/Makefile
>> @@ -40,7 +40,7 @@ define Package/firewall/conffiles
>>   /etc/firewall.user
>>   endef
>>   -TARGET_CFLAGS += -ffunction-sections -fdata-sections
>> +TARGET_CFLAGS += -ffunction-sections -fdata-sections
>> -Wno-error=format-overflow
>>   TARGET_LDFLAGS += -Wl,--gc-sections
>>   CMAKE_OPTIONS += $(if $(CONFIG_IPV6),,-DDISABLE_IPV6=1)
>>   diff --git a/package/system/procd/Makefile
>> b/package/system/procd/Makefile
>> index 5971e0293d..c47ff23352 100644
>> --- a/package/system/procd/Makefile
>> +++ b/package/system/procd/Makefile
>> @@ -37,6 +37,8 @@ endif
>>   CMAKE_OPTIONS += -DEARLY_PATH="$(TARGET_INIT_PATH)"
>>   TARGET_LDFLAGS += $(if $(CONFIG_USE_GLIBC),-lrt)
>>   +TARGET_CFLAGS += -Wno-error=format-truncation
>> +
>>   define Package/procd
>>     SECTION:=base
>>     CATEGORY:=Base system
>
>
> NAK.
>
> Please fix the errors instead of hiding the warning. Both packages are
> OpenWrt specific ones. Shouldn't be that difficult to get the fixes applied.
>
> Mathias
>

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel