[OpenWrt-Devel] [PATCH] kernel: modules: fix kmod-regmap

[John Crispin]

On 30/07/18 22:33, Christian Lamparter wrote:
> This patch fixes the a compile issue that was triggered by
> apm821xx/sata when kmod-regmap was selected.
>
> The CONFIG_REGMAP is declared in drivers/base/regmap/Kconfig
> as type "bool" and not "tristate". Hence the symbol should
> never be set to module, as this confuses the #if CONFIG_REGMAP
> guards in include/linux/regmap.h:
>
> |.../drivers/regulator/core.c:4041: undefined reference to `dev_get_regmap'
> |.../drivers/regulator/core.c:4042: undefined reference to `dev_get_regmap'
> |.../drivers/regulator/core.c:4044: undefined reference to `dev_get_regmap'
> |.../drivers/regulator/helpers.o: In function `regulator_is_enabled_regmap':
> |.../drivers/regulator/helpers.c:36: undefined reference to `regmap_read'
> |...
i started a test build 2 minutes ago to figure this one out :-) thanks !


> Signed-off-by: Christian Lamparter <chunkeey at gmail.com>
> ---
>   package/kernel/linux/modules/other.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/kernel/linux/modules/other.mk b/package/kernel/linux/modules/other.mk
> index 7e18a21db3..dd037cf86c 100644
> --- a/package/kernel/linux/modules/other.mk
> +++ b/package/kernel/linux/modules/other.mk
> @@ -718,7 +718,7 @@ define KernelPackage/regmap
>     SUBMENU:=$(OTHER_MENU)
>     TITLE:=Generic register map support
>     DEPENDS:=+kmod-lib-lzo +kmod-i2c-core
> -  KCONFIG:=CONFIG_REGMAP \
> +  KCONFIG:=CONFIG_REGMAP=y \
>   	   CONFIG_REGMAP_MMIO \
>   	   CONFIG_REGMAP_SPI \
>   	   CONFIG_REGMAP_I2C \


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel