[OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

[Piotr Dymacz]

Hi Etienne,

On 19.01.2018 13:09, Etienne Champetier wrote:
> Hi Piotr,
> 
> 2018-01-19 9:54 GMT+01:00 Piotr Dymacz <pepe2k at gmail.com>:
>> Hi Etienne,
>>
>> On 18.01.2018 22:59, Etienne Champetier wrote:
>>>
>>> Hi All,
>>>
>>> Could someone enable this https://github.com/integration/dco on the
>>> whole OpenWrt github org? (or at least on the packages repo)
>>
>>
>> I think that packages repository already uses Travis CI which checks for
>> such thing like a missing SoB, have a look at [1].
> 
> I'm well aware that the package repo uses Travis, as I'm the one
> fixing it from time to time ;)

Sorry, I don't follow closely packages repository ;)

>> It seems that for openwrt/openwrt drone.io CI is used (I don't know who
>> manages that) but only to check if build fails or not. Maybe we could extend
>> it and include scripts/checkpatch.pl before build? That would save reviewers
>> time pointing out formal issues, not only the missing SoB.
> 
> The interest of using DCO is to have an instant response directly into
> the PR (you don't have to jump into Travis logs)

Makes sense, agree.

> We can also make it mandatory (show "required" on the fail test line)
> Also this is a good minimum check to have on ALL repo
> There are many ways to do it, enabling DCO is a 2 minutes job (if
> someone want to do a similar script and host it that's totally fine
> with me)

I'm OK with DCO enabled for all repos. We should probably give some time 
others to comment and if there are no objections, we can enable it.

-- 
Cheers,
Piotr
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel