[OpenWrt-Devel] [PATCH 5/5] ath79: Add support for Ubiquiti Nanostation M (XW)

[Petr Štetiar]

Mathias Kresin <dev at kresin.me> [2018-12-12 13:40:40]:

Hi,

> > +&eth0 {
> > +	status = "okay";
> > +
> > +	phy-mode = "mii";
> > +	phy-handle = <&phy4>;
> > +	mtd-mac-address = <&eeprom 0x0>;
> 
> Can't the mtd-mac-address be moved to the ar9342_ubnt_xw.dtsi? 

yes, I'll do it.

> Don't we need pll-data here?

Well, I don't think so, as it seems that those defined ar934x.dtsi are good enough
and match what is in ar71xx today. So I've droped it. I'll make it more clear in
v2.

> > +define Device/ubnt_nano-m-xw
> > +  $(Device/ubnt-xw)
> > +  DEVICE_TITLE := Ubiquiti Nanostation M (XW)
> > +  SUPPORTED_DEVICES += nano-m-xw nanostation-m-xw
> 
> I can not find an ar71xx board which uses "nano-m-xw" as userspace
> boardname. What's the purpose of adding the string to the supported devices?

I think, that I've forget to remove nano-m-xw since that's one is added
automatically from device name, but I've added nanostation-m-xw, because I
wasn't able to upgrade from ar71xx without -F.

I wanted to make it first as separate patch with the error message included,
but I've then decided to just add it in the board support patch. Anyway, I've
returned my Nanostation already, so it's going to take some time to reproduce
it again and provide proper explanation for you.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel