[OpenWrt-Devel] [PATCH 8/8] ipq806x: specify "firmware" partition format for NEC Aterm WG2600HP

[Christian Lamparter]

On Sunday, December 9, 2018 4:57:10 PM CET INAGAKI Hiroshi wrote:
> On 2018/12/10 0:34, Christian Lamparter wrote:
> > Specify firmware partition format by compatible string.
> >
> > Cc: INAGAKI Hiroshi <musashino.open at gmail.com>
> > Signed-off-by: Christian Lamparter <chunkeey at gmail.com>
> > ---
> >   .../files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts       | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts b/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts
> > index 580e0f86bb..19fba2d075 100644
> > --- a/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts
> > +++ b/target/linux/ipq806x/files-4.14/arch/arm/boot/dts/qcom-ipq8064-wg2600hp.dts
> > @@ -237,6 +237,7 @@
> >   					};
> >   
> >   					firmware at 860000 {
> > +						compatible = "openwrt,fit-firmware";
> >   						label = "firmware";
> >   						reg = <0x860000 0x17a0000>;
> >   					};
> Hi Christian, thanks your work.
> However, NEC WG2600HP uses standard uImage firmware in OpenWrt, so it
> should to use /compatible = "denx,uimage";/.

Thanks for letting me know, I've dropped the patch. 
> 
> And, I prepared some fixes and cleanups for this device in my repo[1].
> 
> By the way, if set compatible string to "firmware" node that is not
> under "partitions" (compatible = "fixed-partitions") node, the kernel
> could not recognize that node as a partition in WG2600HP.
> Since I could not verify the problem sufficiently, I informed it as a
> reference.

Now that you mention it, I read about this before and I remember where:
This behaviour is described in the partition.txt devicetree binding [0]:

| For backwards compatibility partitions as direct subnodes of the flash device are
| supported. This use is discouraged.
| NOTE: also for backwards compatibility, direct subnodes that have a compatible
| string are not considered partitions, as they may be used for other bindings.

[0] <https://www.kernel.org/doc/Documentation/devicetree/bindings/mtd/partition.txt>

So it's because of backwards compatibility that this will never work.




_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel