[OpenWrt-Devel] [PATCH 2/2] lantiq: enable LEDS_TRIGGER_MTD support

[John Crispin]

On 30/11/2018 00:48, Mathias Kresin wrote:
> 29/11/2018 14:25, Florian Eckert:
>> Enable mtd led trigger for lantiq devices by default to show MTD
>> activity

Hi,

this is a very specific feature and I dont see any devices in tree using 
the driver. it'll increase the image size and we have several small 
flashed units in the target. cant you simplly make it AutoProbe during 
preinit ? there is next to no flash activity until preinit anyway.

    John



>>
>> Signed-off-by: Florian Eckert <fe at dev.tdt.de>
>> ---
>>   target/linux/lantiq/config-4.14 | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/target/linux/lantiq/config-4.14 
>> b/target/linux/lantiq/config-4.14
>> index 055a428792..938aafc1f5 100644
>> --- a/target/linux/lantiq/config-4.14
>> +++ b/target/linux/lantiq/config-4.14
>> @@ -127,6 +127,7 @@ CONFIG_LANTIQ_ETOP=y
>>   CONFIG_LANTIQ_WDT=y
>>   # CONFIG_LANTIQ_XRX200 is not set
>>   CONFIG_LEDS_GPIO=y
>> +CONFIG_LEDS_TRIGGER_MTD=y
>>   CONFIG_LIBFDT=y
>>   CONFIG_MDIO_BUS=y
>>   CONFIG_MDIO_DEVICE=y
>>
>
> Please move it to a subtarget config.
>
> This change will be applied to xway_legacy as well, which is our 
> subtarget for boards with only 4 MByte of flash. Wasting flash space 
> with a trigger not even used by any of the lantiq boards in the tree 
> is a no go.
>
> Mathias
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel