[OpenWrt-Devel] [PATCH v2] apm821xx, ath79, ipq40xx, ipq806x, lantiq, ramips: base-files: Use generic diag.sh

[Christian Lamparter]

On Wednesday, November 28, 2018 8:48:14 AM CET Petr Štetiar wrote:
> I wanted to add status LEDs support to my imx6 based board and have found out,
> that I could use diag.sh script found in ramips platform, which seems to be
> also shared in a few other platforms:
> 
>  4801276bc2078c5bcf03003c831e3b0a target/linux/ramips/base-files/etc/diag.sh
>  4801276bc2078c5bcf03003c831e3b0a target/linux/ipq40xx/base-files/etc/diag.sh
>  4801276bc2078c5bcf03003c831e3b0a target/linux/ath79/base-files/etc/diag.sh
> 
> And @chunkeey suggested to me, that I can also add lantiq, ipq806x and
> apm821xx to the list of platforms which could share this generic
> diag.sh.
> 
> I've extended the base diag.sh in a way, that if it detects any of the
> DTS LED aliases, then it would use the generic DTS set_led_state code.
> The code in platform's diag.sh has moved to base-files package in this
> commit:
> 
>  base-files: diag.sh: Make it more generic towards DTS so it could be reused
> 
> Signed-off-by: Petr Štetiar <ynezz at true.cz>
Tested-by: Christian Lamparter <chunkeey at gmail.com> (apm821xx and ipq40xx)


I think there is a misunderstanding bound to happen here.

Mathias marked the (v1) series which includes the important 
"base-files: diag.sh: Make it more generic towards DTS so it could be reused"
as superseeded (<https://patchwork.ozlabs.org/patch/1003936/>) because you
posted this patch as "v2". But you didn't include the "base-files: diag.sh ..."
patch in the series since nothing changed. I think the easiest way to resolve
this potential issue would be to repost both 
"base-files: diag.sh: Make it more generic towards DTS so it could be reused"
"apm821xx, ath79, ipq40xx, ipq806x, lantiq, ramips: base-files: Use generic diag.sh"

with a "v3" tag. (Or Mathias/you update the status of the base-file patch).

Thanks,
Christian



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel