[OpenWrt-Devel] [PATCH packages] pptpd: run service in foreground for procd compatibility

[Rafał Miłecki]

On 28 September 2016 at 00:37, Luka Perkov <luka at openwrt.org> wrote:
> On Mon, Sep 26, 2016 at 07:59:30AM +0200, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal at milecki.pl>
>>
>> To have service working nicely with procd it should be running in the
>> foreground. Otherwise it's not possible to e.g. stop it with the init.d
>> script. Luckily for us pptpd has a simple switch that allows it.
>>
>> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
>> Fixes: 15e7f611afb ("pptpd: convert init script to procd")
>> ---
>> Hi Luka,
>>
>> This pptpd package with broken procd compatibility has been also backported
>> to the for-15.05 branch. Can you apply this fix to for-15.05 as well, please?
>
> Thank you for the patch. We are using for quite a while GitHub pull
> request workflow for all packages in the feeds. Please take a look at
> the documentation:
>
> https://github.com/openwrt/packages/blob/master/CONTRIBUTING.md
>
> That said, can you make a pull request?

I'm not really comfortable using that proprietary service and its
terrible UI. Could you consider accepting this e-mail submitted patch?
You could trivially apply it with a single command:
curl https://patchwork.ozlabs.org/patch/674965/mbox/ | git am
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel