[OpenWrt-Devel] pppd: Someone please fix the Makefile to install net/pppd_defs.h so my pull request for rp-pppoe can go through

[Luke McKee]

https://github.com/openwrt/packages/pull/2974

Attention @jow- @champtar
Also users with historical interest with rp-pppoe
http://git.openwrt.org/?p=packages.git;a=history;f=net/rp-pppoe;h=c4c326bf49614aa8ef4ef224b747af01100ef242;hb=HEAD
@hauke @nbd168
Quote:
6bcfc3a

For this package to compile, it just needs openwrt pppd to install
net/ppp_defs.h into the staging area that requires a small modification
to package pppd Makefile
openwrt/openwrt at 5de3ef3

< i.e. this change to pppd Makefile :
https://github.com/openwrt/openwrt/commit/5de3ef3 >

from pull request: openwrt/openwrt#15

Could the package maintainer please expedite this, as @jow said every
package should copy the file from pppd and patch it in which is just insane.

rp-pppoe is not recommended for production environments nearly everone
on the internet as an access concentrator, but it's better than nothing
(what openwrt has now). In the near future I'll also try to merge
accel-ppp, that is much better as it supports snmp, doesn't fork pppd
processes and is completely kernel mode only.

Changes made.
1) Stopped building installing the pppoe client (usermode) & rp-pppoe.so
as it's already provided by pppd to prevent conflicts.
2) Did a fix for musl 1.1 compatibility inspired by:
e76f394
3) Saw a very large free memory limit hardcoded into rp-pppoe that was
ignored if you bought the commercial verison. Lowered it to a more
conservative value considering musl apps compiled with -Os 3) Saw a very
large free memory limit hardcoded into rp-pppoe that was ignored if you
bought the commercial verison. Lowered it to a more conserative value
considering musl apps compiled with -Os 3) Saw a very large free memory
limit hard-coded into rp-pppoe that was ignored if you bought the
commercial verison. Lowered it to a more conserative value considering
compiling with musl & -Os have much less memory demands
4) changed the default options
5) Overrode configure to use the already installed rp-pppoe.so, the
location of this library and even the mtu 1492 (if larger than 1500 is
set) is hardcoded in the pppoe-server binary

There is no uci or procd init scripts support yet. Most people wont want
this and will use their own ppp if-up/down scripts to manage how their
want their PPPOE access concentrator set up. If there is demand for this
I will do it, if I get package maintainer status for this one.

Compile-tested: Openwrt Buildroot, gcc 5.0, fortify, RELRO, SSP
conserative
Run-Tested: Not yet, but great care was taken the package was configured
correctly reviewing the source, config.h and the defines. You may leave
the pull request open until my testing is complete. I rather just
get it out there now the minority of openwrt users who are interested
in using this.

Signed-off-by: Luke McKee hojuruku at gmail.com

https://dev.openwrt.org/ticket/21350
Seven months ago someone nagged for this to be fixed. That makes only
two people that want this :)

>Changed 7 months ago by @nbd168
>Resolution set to wontfix
>Status changed from new to closed
>rp-pppoe is unmaintained, no changes will be made until it is cleaned up and submitted to the github repo.

DONE.
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel