[OpenWrt-Devel] [PATCH v3] base-files: For sysfixtime use hwclock if RTC available

[Petr Štetiar]

Bastian Bittorf <bittorf at bluebottle.com> [2016-01-21 12:53:48]:

> * Petr Štetiar <ynezz at true.cz> [21.01.2016 12:22]:
> >  boot() {
> > +	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ] && $HWCLOCK -s -f $RTC_DEV && exit 0
> 
> thank you! can you please do in this line a:
> && return

Like following?

	deps_ok && $HWCLOCK -s -f $RTC_DEV && exit 0 && return 

Is it really needed? I've always thought, that exit will terminate the script
so the return wouldn't be called anyway.

> and introduce a helper (maybe overengineered 8-)

Kind of, was thinking about it also so I'll change it, thanks.

> deps_ok() {
> 	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ]
> }

-- ynezz
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel