[OpenWrt-Devel] [PATCH] brcm63xx: fix gpio ephy-reset

[dani]

Thanks Jonas. Tested and working OK. It would be nice if the patch is also
backported to Chaos Calmer revision.

Regards.

2016-01-18 14:16 GMT+01:00 Jonas Gorski <jogo at openwrt.org>:

> Hi,
>
> On 12 December 2015 at 14:10, dani <dgcbueu at gmail.com> wrote:
> > Currently ephy-reset, which uses a GPIO for enabling external ethernet
> phys, is broken.
> > This patch fix the problem.
> >
> > This problem causes in boards with external phys with a reset pin
> connected to gpio, are
> > initialized without lan interfaces.
> >
> > The line
> > ephy_reset.table[0].chip_label = gpio_chip_labels[hw_gpio / 32];
> > always returns bcm63xx-gpio.1. As a result of this, reset pins connected
> to gpios <32
> > will return messages "gpio X out of range", and ethernet fails to
> initialize.
> >
> > The array *gpio_chip_labels[] should be initialized with different names
> for each element,
> > otherwise sprintf will copy the label of the gpio chip for both elements
> at the same time.
> > And the name of both elements of the array will be the same.
> >
> > Using a different name on the second array element solves the problem.
> > Signed-off-by: Daniel Gonzalez <dgcbueu at gmail.com>
>
> I added a slightly different approach in r48303, can you verify it
> works for you?
>
>
> Jonas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20160118/b42f1769/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel