[OpenWrt-Devel] [PATCH] brcm63xx: add support for ZyXEL P870HNU-51b

[Jonas Gorski]

Hi,

On 20 December 2015 at 04:52, Mohammed Berdai <mohammed.berdai at gmail.com> wrote:
> This router is a ZyXEL VDSL2 router and its board has :
> chip ID: BCM6368B2, MIPS: 400MHz,
> Total Flash size: 16384K with 128 sectors
> Total Memory: 67108864 bytes (64MB)
> Board Id (0-15): 96368MVWG
>
> with a usb port, and wifi Broadcom bcm43222.
> This router requires the image to have: --signature "ZyXEL_4004" -pad
> 8 --image-offset 0x20000
>
> this patch is for Trunk (compiled and tested against  trunk at 47953
> 3c298f89-4303-0410-b956-a3cf2f4a3e73 )
>
>

You are missing a Signed-off-by, also your patch does not apply:

Applying patch #559307 using 'git am'
Description: [OpenWrt-Devel] brcm63xx: add support for ZyXEL P870HNU-51b
Applying: brcm63xx: add support for ZyXEL P870HNU-51b
fatal: corrupt patch at line 167

it looks like your email program broke the patch by wrapping lines,
replacing all tabs with spaces and removing trailing spaces. Please
fix and resend. I highly suggest using git send-email for sending
patches.

Also ..

> diff --git a/target/linux/brcm63xx/base-files/etc/board.d/02_network
> b/target/linux/brcm63xx/base-files/etc/board.d/02_network
> index c01aba8..061871c 100755
> --- a/target/linux/brcm63xx/base-files/etc/board.d/02_network
> +++ b/target/linux/brcm63xx/base-files/etc/board.d/02_network
> @@ -88,6 +88,7 @@ fast2504n |\
>  fast2704v2 |\
>  hg655b |\
>  p870hw-51a_v2 |\
> +p870hnu-51b |\

Please use alphabetical ordering where appropriate.

(snipped rest)


Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel