[OpenWrt-Devel] [PATCH] swconfig: support setting SWITCH_TYPE_LINK attributes

[Stefan Rompf]

Hi,

On Montag, 11. Januar 2016 23:45:39 Rafał Miłecki wrote:

> > Any comments to this usage/syntax? It doesn't look too nice (this long
> > quoted string as a value), but swconfig is strongly focused on simple
> > values.
> 
> One more RFC... anyone?

I am not an OpenWRT core developer so I cannot comment on the niceness of the 
interface ;-) The string does not allow to specify combinations like autoneg 
on, advertise 10 and 1000, but not 100, but that would be a very esoteric use 
case and it is about configuring a switch port and not an ethernet tester. 
IMHO for the normal use case, it allows to specify everything that is needed.

So for me it's all right.

Stefan
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel