[OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

[Daniel Dickinson]

On 10/01/16 06:11 AM, John Crispin wrote:
>
>
> On 10/01/2016 11:32, Daniel Dickinson wrote:
>> I'm sure this has been discussed to death, but having patchwork be a
>> knob isn't the answer.
>
> at which point did patchwork get part of the equation ?

I had assumed it was an automatic detection from a program, not a visual 
inspection thing.  My bad.

>
> i simple looked over the mails in my inbox in the morning and saw that
> there are 8 leading spaces instead of a tab.
>
> "+\t" will render 8 byes wide while "+        " renders 9 byte wide in
> my mail client. that is how i spotted it.
>

I will change this, but seriously, 8 spaces instead of tab in a shell 
script is cause reject a patch?

I think priorities are seriously skewed when an error that you need a 
particular mail client to spot the error (and even with the regexes you 
gave error wasn't detected, nor did git complain) is a more than a 
little excessive.

Regards,

Daniel
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel