[OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

[Daniel Dickinson]

On 10/01/16 06:30 AM, Hartmut Knaack wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Daniel Dickinson schrieb am 10.01.2016 um 11:32:
>> And yes you could make a regex that detect any sets of 8 spaces before
>> non-whitespace text, but that seems like a lot of effort for no good
>> reason, when not dealing with Makefiles.
>>
>> Anything that applies a *hard* rule about whitespace is broken -
>> whitespace shouldn't be getting converted unless it's actually
>> necessary; a hard rule will fail under some conditions, and the real
>> issue is editors *changing* whitespace without user interaction (which
>> causes patches to fail).
>>
>> Indead git's insistence on the exact same whitespace is the root issue,
>> since changing git would be a lot easier than changing a bazillion
>> editor to suite git (hint: ain't gonna happen).
>>
>> I'm sure this has been discussed to death, but having patchwork be a
>> knob isn't the answer.
>>
>> Regards,
>>
>> Daniel
>>
>
> Dude, no offense, but do you really think this is the right way to go? John
> pointed out the place where the problem occurred, and instead of checking your

Actually I did check my patch, in fact I tried using a vim highlighter 
thing that John suggested and neither it nor git spotted the problem.

If detected the problem my manual moving the cursor over the offending 
location.

It really *shouldn't* take moving the cursor over every bit of 
whitespace to find an error.  Yes a better regex will help, but it 
doesn't alter the fact that being draconian about whitespace is 
counter-productive to community involvement.

I had assumed it was automatic detection, (hence the comments about 
Patchwork), not something someone has added as their own personal 
excessively OCD-esque requirements.

Regards,

Daniel


> patch (takes maybe 2 minutes) you send 3 mails and speculate about unrelated
> things. These small format issues happen to all of us some time, so I'd
> recommend to take it easy, investigate more in the problem and think twice
> before you send like 3 mails within one hour, mainly replying to yourself.
> That said, I appreciate your effort in OpenWrt development and have no
> intention to discourage you.
> Keep up the good work.
>
> Hartmut
>
>> On 10/01/16 05:20 AM, Daniel Dickinson wrote:
>>> Hi,
>>>
>>> On 10/01/16 05:10 AM, Gert Doering wrote:
>>>> Hi,
>>>>
>>>> On Sun, Jan 10, 2016 at 04:47:05AM -0500, Daniel Dickinson wrote:
>>>>> I used git send-email so there shouldn't be any whitepspace mangling
>>>>> issues, unless patchwork is to blame.
>>>>
>>>> Over at openvpn-devel, we recently discovered that some versions of
>>>> MS Exchange mangle whitespace for "mails in transit" - so even when the
>>>> user did everything right (git send-email, etc.) Exchange still converted
>>>> all tabs to 8x Space, leading to non-applying patches.
>>>>
>>>
>>> I think this is a different issue. The issue here is that there is
>>> indeed 8 spaces instead of a tab, *however* it's in a shell script AND
>>> git doesn't complain, nor do regexes that detect things like spaces
>>> before tabs (there is no tab after the spaces, only non-whitespace
>>> text). In short patchwork appears to say 'for *all* files, you *must*
>>> use tab instead of 8 spaces', which is not reasonable, and in some cases
>>> is actually wrong.
>>>
>>> Also I am pretty certain provider is not running Windows, nor is
>>> OpenWrt, so that is not likely to at issue.
>>>
>>>> Solution: send via freemail provider, using direct SMTP+Auth (which
>>>> git send-email can do).
>>>>
>>>>> That leaves receive-side error.  It seems likely given the line the
>>>>> error is on, that patchwork is pickier than git or the vim bit you sent
>>>>> me.  That is the 'offending' line is a shell script that happens to have
>>>>> 8 spaces instead of tab.  Methinks this is not a relevant thing to
>>>>> complain about in a shell script; also I wonder whether it would do the
>>>>> same with with e.g. Python?  I suspect patchwork is applying Makefile
>>>>> rules to all patches, which is just wrong.
>>>>
>>>> The problem often is context.  If the parts before or after the actual
>>>> change get whitespace-modified, git am will not accept it (traditional
>>>> patch will, and complain about fuzz needed).
>>>
>>> However, the error being reported is not 'patch does not apply', it is
>>> 'whitespace error', which implies that it's something patchwork is
>>> reporting.
>>>
>>> Perhaps the error report really should be 'patch does not apply because
>>> of whitespace error', but that is not what I was told, so I'm left
>>> guessing.
>>>
>>> Regards,
>>>
>>> Daniel
>>> _______________________________________________
>>> openwrt-devel mailing list
>>> openwrt-devel at lists.openwrt.org
>>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>>>
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel at lists.openwrt.org
>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJWkkDZAAoJEANoShj6yJFIdFIP/3nmjDmF3I2og74EmiPg4iaz
> UwERlG1/dXy9mPc/DFg+3Eu9EoilGGfemoS7rSBHqJnxBIvxB18226Foe235x3S0
> 9KUCi3EmiqW5UYUHBg8PcZqKLJ2fRExfTyXhetWqs3UWN4D3Ah14aAK2cktEz4YD
> 1Nfnru1d0YLeoHVQvetILsozdbYxuyqOw74gKK/VtsOPiz5WAiwfKie7w47cunOX
> ObnNNLxxW1+7fnPyFDv6vVtGpJkO79oywd4s74YqUT6xX1o164t46v86Tnn5C3Uj
> HJTpTVxNgNCd0NJ6CbbWzWcnVyUuqdD0qIyYmZt29Tdse+fOO1V5iHUbR5L7vjNw
> RdGg3CRXAgrq1J8+bsTbD+t1CdY35teE8s4Ayy13sMKtVr1rhqXBgAvSVhcpRRtF
> fWWJHfr2zAag13/wkv/lqZfDquFT0IxgTVDzINrBrE1roq6JkUy+gEZnrOiardnp
> f1Zj8xbuoi/1vQRb/NhM5gWKDK+MBlWjPHqpXiOnv9lsaDQBQvMi5V4+haBZrAM2
> FWG9tVYpO+4mz02/jG0aemwUkRmj3In0RBfyCJNpBjKhfy0zknyT+pc7CxKacYPO
> Nap7h5hqV6EsQ+XYCivugR/lfXrXwgXAZ5aDkGIO8puFHino0Awgx0PV29+BmwZw
> lTGhvC95sv2DCqPIiqYS
> =Y9Sd
> -----END PGP SIGNATURE-----
>
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel