[OpenWrt-Devel] [PATCH 1/1] include/autotools.mk: rename libtool to libltdl

Daniel Dickinson openwrt at daniel.thecshore.com
Sat Jan 9 17:06:00 EST 2016


Actually it turns out I was right: This depends on 'source' package not 
binary package, therefore the patch I am verifying (doing a test SDK 
compile to verify nothing broke) is required.

Regards,

Daniel

On 09/01/16 04:15 PM, Daniel Dickinson wrote:
> Never mind, I'm confusing source package and binary package; I'm not
> sure which this particular use depends on.
>
> Regards,
>
> Daniel
>
> On 09/01/16 04:07 PM, Daniel Dickinson wrote:
>> I do not believe this is the right fix:
>>
>> The PKG_NAME is libtool so the the package name
>> should be found as libtool not libltdl.
>>
>> I have a patch I am testing that fixes the metadata.pm
>> issue and will correctly use libtool as the soure
>> package name.
>>
>> Regards,
>>
>> Daniel
>>
>> On 09/01/16 03:58 PM, Heinrich Schuchardt wrote:
>>> Fixes #21567
>>>
>>> Since commit e49896f232ed2ed76f6a67cfb6c4f9bc3ac01af
>>> package/libs/libtool: rename to libltdl
>>> we see warnings like
>>>
>>> "WARNING: No feed for package 'libtool' found, maybe it's already
>>> part of
>>> the standard packages?"
>>>
>>> for packages with PKG_FIXUP:=libtool.
>>>
>>> Build dependencies for libtool are generated in autotools.mk.
>>> These have to be renamed to libltdl.
>>>
>>> CC: Daniel Dickinson <openwrt at daniel.thecshore.com>
>>> CC: Felix Fietkau <nbd at openwrt.org>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>> ---
>>>   include/autotools.mk | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/autotools.mk b/include/autotools.mk
>>> index 3316998..4d25c85 100644
>>> --- a/include/autotools.mk
>>> +++ b/include/autotools.mk
>>> @@ -105,14 +105,14 @@ ifneq ($(filter patch-libtool,$(PKG_FIXUP)),)
>>>   endif
>>>
>>>   ifneq ($(filter libtool,$(PKG_FIXUP)),)
>>> -  PKG_BUILD_DEPENDS += libtool libintl libiconv
>>> +  PKG_BUILD_DEPENDS += libltdl libintl libiconv
>>>    ifeq ($(filter no-autoreconf,$(PKG_FIXUP)),)
>>>     Hooks/Configure/Pre += autoreconf_target
>>>    endif
>>>   endif
>>>
>>>   ifneq ($(filter libtool-ucxx,$(PKG_FIXUP)),)
>>> -  PKG_BUILD_DEPENDS += libtool libintl libiconv
>>> +  PKG_BUILD_DEPENDS += libltdl libintl libiconv
>>>    ifeq ($(filter no-autoreconf,$(PKG_FIXUP)),)
>>>     Hooks/Configure/Pre += autoreconf_target
>>>    endif
>>>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list