[OpenWrt-Devel] [PATCH 2/5] lantiq/xrx200-net: fix PCE_MAPx handling

[Felix Fietkau]

On 2016-02-22 13:17, Martin Schiller wrote:
> On 02/20/2016 at 10:59 AM, Felix Fietkau wrote:
>> On 2016-02-18 14:13, Martin Schiller wrote:
>> > Remove unnecessary MPMAP (PCE_MAP1) initialization and make
>> DMCPMAP (PCE_MAP2)
>> > and UUCMAP (PCE_MAP3) configurable from user space.
>> >
>> > Signed-off-by: Martin Schiller <mschiller at tdt.de>
>> This looks a lot like a low level implementation detail that should not
>> be exposed to the configuration. Please provide an explanation of how
>> exactly these port map registers works, so we can figure out a way to
>> set it dynamically from within the driver.
>>
>> - Felix
> 
> MPMAP is the map of ports to which incoming frames shall be sent for
> monitoring.
> 
> There are a lot of other registers where you can configure which kind of
> frames shall be monitored. So adding ports to the MPMAP without further
> configuration doesn't make sense, and so the MPMAP initialization should
> be removed.
> 
> DMCPMAP is the map of ports to which incoming unknown multicast and
> broadcast frames shall be sent.
> 
> UUCMAP ist he map of ports to which incoming unknown unicast frames
> shall be sent.
> 
>  I introduced this configure options, because they were helpful to figure
> out the behaivor of this mappings while I was "fighting" with the LAN/WAN port
> separation, but there is actually no really strong need to have access to this
> registers from userspace.
> 
> So my thought was that it won't hurt or break anything else when I add the
> opportunity to change this register values from userspace.
I don't like this kind of random debug stuff in swconfig. How about you
add a plain debugfs interface instead that can read/write any register.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel