[OpenWrt-Devel] [PATCH 4/5] lantiq/xrx200-net: add FID (filtering identifier) setting

[John Crispin]

On 18/02/2016 14:13, Martin Schiller wrote:
> By setting the FID of a VLAN group to a value other then the default (0) it
> is possible to switch from Shared VLAN Learning to Independant VLAN Learning.
> 

and what are the pro / cons of doing so ?

[...]

>  +static int xrx200sw_set_vlan_ports(struct switch_dev *dev, struct switch_val *val)
>  +{
>  +	int i, portmap, tagmap, untagged;
> @@ -1022,6 +1051,14 @@ Subject: [PATCH 25/36] NET: MIPS: lantiq: adds xrx200-net
>  +	},
>  +	{
>  +		.type = SWITCH_TYPE_INT,
> ++		.name = "fid",
> ++		.description = "Filtering Identifier (0-63)",
> ++		.set = xrx200sw_set_vlan_fid,
> ++		.get = xrx200sw_get_vlan_fid,
> ++		.max = 63,
> ++ 	},


i am not sure it is a good idea to export these options to user(land).
why do you need them ?

> ++	{
> ++		.type = SWITCH_TYPE_INT,
>  +		.name = "enable",
>  +		.description = "Enable VLAN",
>  +		.set = xrx200sw_set_vlan_enable,
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel