[OpenWrt-Devel] [PATCH] package/devel/perf: fix build for kernel 4.1

[John Crispin]

On 26/10/2015 12:48, Alexandru Ardelean wrote:
> Looks like it did not take much to actually come back with an answer.
> So,
> 
> In file:
> https://github.com/torvalds/linux/blob/v4.1/tools/perf/Makefile.perf
> Line 75:   # Define NO_LZMA if you do not want to support compressed
> (xz) kernel modules
> 
> Then file:
> https://github.com/torvalds/linux/blob/v4.1/tools/perf/config/Makefile
> Lines 544-553:
> 
> ifndef NO_LZMA
>   ifeq ($(feature-lzma), 1)
>     CFLAGS += -DHAVE_LZMA_SUPPORT
>     EXTLIBS += -llzma
>     $(call detected,CONFIG_LZMA)
>   else
>     msg := $(warning No liblzma found, disables xz kernel module decompression, please install xz-devel/liblzma-dev);
>     NO_LZMA := 1
>   endif
> endif
> 
> In my case it seems to enable by default.
> 
> Looking at the same files in 3.18:
> https://github.com/torvalds/linux/blob/v3.18/tools/perf/config/Makefile
> https://github.com/torvalds/linux/blob/v3.18/tools/perf/Makefile.perf
> 
> No mention of these.
> 
> Going a bit deeper, I found this commit:
> https://github.com/torvalds/linux/commit/80a32e5b498a7547073e5e4b2b804edc7219979d
> where LZMA compression gets added to perf.
> 
> Looks like it was enabled default in upstream.
> 
> So, I guess, we could build perf with NO_LZMA:=1 defined and we could
> disable it.
> No strong preferences from me.
> 
> Your call :)

oh thanks, detailed analysis :) as our FS already doe LZMA and our kmods
are not compressed i think it is best to set NO_LZMA. could you
create/test a patch and i will mark the current version as "Changes
Requested"

	John
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel