[OpenWrt-Devel] [packages] broken package: procd is broken in 15.05 (#1879)

[Carlos Ferreira]

Daniel
Your patch did not work without some simple modifications.
Instead of having

*inline __attribute__((always_inline)) int ignore(int x) {return x;}*
at procd.h, I had to add a

*static inline __attribute__((always_inline)) int ignore(int x) {return x;}*
at the begining of both coldplug.c and early.c.
I did this because early.c was not including procd.h

After the change, the rest of the patch (adding ignore()) worked and procd
compiled.

Thanks for the help and effort. The fix should be submitted to repo so that
the x86 with glibc variant may be compilable.


On 22 October 2015 at 17:04, Daniel Gimpelevich <
daniel at gimpelevich.san-francisco.ca.us> wrote:

> On Thu, 2015-10-22 at 17:54 +0200, Felix Fietkau wrote:
> > On 2015-10-21 01:34, Daniel Golle wrote:
> > > Hi!
> > >
> > > This has been an argument going on between the gcc and the glibc people
> > > for about 10 years now.
> > > See
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509
> > >
> > > It seems like commit b6618ffa which added the symlinks silently broke
> > > things when building with glibc.
> > > Don't ask me why glibc enabled warn_unused_result for symlink(3) but
> > > doesn't for found mount(2) or mkdir(3)...
> > >
> > > A way around it would be to take things as they are and simply make
> > > sure to surpress the warning as shown in
> > > http://www.redhat.com/archives/rhl-devel-list/2007-March/msg00692.html
> [snip]
> > inline functions should be static. the always_inline part is irrelevant
> > here.
> >
> > - Felix
>
> Maybe it can just be typecast to void? This kind of issue was one of the
> last things I expected. I first learned C before ANSI or ISO had even
> draft standards, and I guess it still shows.
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>



-- 

Carlos Miguel Ferreira
Researcher at Telecommunications Institute
Aveiro - Portugal
Work E-mail - cmf at av.it.pt
Skype & GTalk -> carlosmf.pt at gmail.com
LinkedIn -> http://www.linkedin.com/in/carlosmferreira
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20151022/2879a494/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel