[OpenWrt-Devel] [PATCH procd v2 00/17] ujail fs jail rework/fixes/improvements

[John Crispin]

Hi,

On 25/11/2015 18:54, Etienne CHAMPETIER wrote:
> As requested, i've split up in smaller patches my work
> I also follow the unwritten code style requirement :)
> 
> "rework fs jail part" commit is still a bit big
> but if i split it further i will edit the same line
> in each commit (tell me if it too big)
> 
> Etienne CHAMPETIER (17):
>   ujail: don't add non existant library_path
>   ujail: don't pass unused arg in clone call
>   ujail: stop using extern in elf.h
>   ujail: use more const in elf.*
>   ujail: use "#pragma once" in .h where needed

apart from this patch the series looks good. i'll have another go at
reading it in the morning.

	John


>   ujail: add <stdio.h> to log.h
>   ujail: add <stdio.h> and <syslog.h> to seccomp.h
>   ujail: remove "#include log.h" from elf.h
>   ujail: search libs in /lib before /lib64
>   ujail: use PATH_MAX for path related buffers
>   ujail: add init_library_search()
>   ujail: fixup code style: "func()" -> "func(void)"
>   ujail: remove some debug/dev hack
>   ujail: DT_STRTAB uses d_ptr in d_un union (not d_val)
>   ujail: rework fs jail part
>   ujail: automatically add script (#!) interpreter
>   ujail: add ELF interpreter (DT_INTERP) to the jail
> 
>  CMakeLists.txt      |   2 +-
>  jail/capabilities.h |   1 +
>  jail/elf.c          | 154 +++++++++++++++++---------------------------
>  jail/elf.h          |  15 ++---
>  jail/fs.c           | 181 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  jail/fs.h           |  18 ++++++
>  jail/jail.c         | 118 +++++++++++-----------------------
>  jail/jail.h         |  15 +++++
>  jail/log.h          |   2 +
>  jail/preload.c      |   2 -
>  jail/seccomp.c      |   2 -
>  jail/seccomp.h      |   4 ++
>  12 files changed, 322 insertions(+), 192 deletions(-)
>  create mode 100644 jail/fs.c
>  create mode 100644 jail/fs.h
>  create mode 100644 jail/jail.h
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel