[OpenWrt-Devel] [PATCH] mpc85xx: TL-WDR4900: Fix port 6 being shown as up (10MBit/half) in LUCI/swconfig

[John Crispin]

On 12/05/2015 21:24, Heiner Kallweit wrote:
> Currently port 6 is shown as up 10MBit/half in LUCI and swconfig.
> Reason is that all bits in the port 6 config are zero.
> This means that also the aneg flag is not set and in this case
> ar8216_read_port_link hardcodes the link to be up.
> 
> This is no real problem but a little annoying.
> To fix this initialize port 6 with the aneg bit enabled.
> This causes ar8216_read_port_link to evaluate the link status bit which is
> always zero for port 6 as no PHY is connected to this port.
> And it doesn't hurt as port 6 isn't connected to anything on TL-WDR4900.

are you sure ? dangling ports that are powered up tend to eat up power
and convert it to heat. i would tend to nack this patch.

	John




> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
> ---
>  target/linux/mpc85xx/files/arch/powerpc/boot/dts/tl-wdr4900-v1.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/linux/mpc85xx/files/arch/powerpc/boot/dts/tl-wdr4900-v1.dts b/target/linux/mpc85xx/files/arch/powerpc/boot/dts/tl-wdr4900-v1.dts
> index 7e48e23..2beb39c 100644
> --- a/target/linux/mpc85xx/files/arch/powerpc/boot/dts/tl-wdr4900-v1.dts
> +++ b/target/linux/mpc85xx/files/arch/powerpc/boot/dts/tl-wdr4900-v1.dts
> @@ -103,6 +103,7 @@
>  					0x00058 0xcf35cf35 /* LED_CTRL2 */
>  					0x0005c 0x03ffff00 /* LED_CTRL3 */
>  					0x0007c 0x0000007e /* PORT0_STATUS */
> +					0x00094 0x00000200 /* PORT6_STATUS */
>  				>;
>  			};
>  		};
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel