[OpenWrt-Devel] [PATCH] brcm63xx: Add Huawei HG655b support

[Jonas Gorski]

Hi,

On Sat, May 9, 2015 at 1:06 PM, Cezary Jackiewicz
<cezary.jackiewicz at gmail.com> wrote:
> Dnia 2015-05-09, o godz. 12:37:30
> dani <dgcbueu at gmail.com> napisał(a):
>
>> This patch adds support for the Huawei HG655b.
>>
>> Nothing much special in this router, it's just another BCM6368 with
>> a Ralink RT3062 wifi chip and the calibration data embedded in the
>> main flash chip at offset 0x7c0000. There is also configuration data
>> used by the OEM firmware before the cal_data partition, this area is
>> protected by the board_data partition in this patch.
>>
>> Signed-off-by: Daniel Gonzalez <dgcbueu at gmail.com>
>> diff --git a/target/linux/brcm63xx/base-files/etc/diag.sh b/target/linux/brcm63xx/base-files/etc/diag.sh
>> index 03d98b9..c330674 100644
>> --- a/target/linux/brcm63xx/base-files/etc/diag.sh
>> +++ b/target/linux/brcm63xx/base-files/etc/diag.sh
>> @@ -89,6 +89,9 @@ set_state() {
>>       hg520)
>>               status_led="HW520:green:net"
>>               ;;
>> +     hg655b)
>> +             status_led="HW65x:green:power"
>> +             ;;
>
> Hi,
> please use generic led name, like "huawei:green:power".

Documentation/leds/leds-class.txt says

"devicename:colour:function"

And "huawei" is hardly a useful devicename. So if we want a generic
name, then something along "board:green:power" would be a more
sensible option. But I'm also fine with the model name, I have no
strong preference there.


Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel