[OpenWrt-Devel] [PATCH 6/7] ap6210-firmware: new package

[Zoltan HERPAI]

Hi,

Daniel Golle wrote:
> This package contains the WiFi NVRAM distributed with Bananian [1].
> It's currently needed to use the WiFi module (BCM43362 SDIO) on the
> BananaPro with the brcmfmac cfg80211 driver which doesn't yet support
> retrieving calibration data via device-tree or platform_data.
>
> (DOS-style newlines in nvram_ap6210.txt are supposedly intentional)
>
>  [1]: http://dl.bananian.org/releases/bananian-latest.zip
>
> Signed-off-by: Daniel Golle <daniel at makrotopia.org>
> ---
>  package/firmware/ap6210-firmware/Makefile          | 40 +++++++++++++++
>  .../ap6210-firmware/files/nvram_ap6210.txt         | 57 ++++++++++++++++++++++
[snip]


> --- /dev/null
> +++ b/package/firmware/ap6210-firmware/files/nvram_ap6210.txt
> @@ -0,0 +1,57 @@
> +#AP6210_NVRAM_V1.2_03192013
> +manfid=0x2d0
> +prodid=0x492
> +vendid=0x14e4
> +devid=0x4343
> +boardtype=0x0598
> +
> +# Board Revision is P307, same nvram file can be used for P304, P305, P306 and P307 as the tssi pa params used are same
> +#Please force the automatic RX PER data to the respective board directory if not using P307 board, for e.g. for P305 boards force the data into the following directory /projects/BCM43362/a1_labdata/boardtests/results/sdg_rev0305
> +boardrev=0x1307
> +boardnum=777
> +xtalfreq=26000
> +boardflags=0x80201
> +boardflags2=0x80
> +sromrev=3
> +wl0id=0x431b
> +macaddr=00:90:4c:07:71:12
>   
[snip]

Hardcoding the MAC address doesn't seem ideal - cna you autogenerate 
this file and at least make the MAC random? Generating it at build time 
would be fine.

Regards,
-w-
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel