[OpenWrt-Devel] [PATCHv2 5/7] mac80211/linux-firmware: include firmware for brcmfmac-sdio

[Rafał Miłecki]

On 30 July 2015 at 10:52, Daniel Golle <daniel at makrotopia.org> wrote:
> @@ -2000,6 +2000,50 @@ endef
>
>  define KernelPackage/brcmfmac/install
>         $(INSTALL_DIR) $(1)/lib/firmware/brcm
> +ifneq ($(CONFIG_BRCMFMAC_SDIO),)
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43143-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43241b0-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43241b4-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43241b5-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4329-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4330-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4334-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4334-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43340-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43362-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4339-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43430-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac43435-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +       $(INSTALL_DATA) \
> +               $(PKG_BUILD_DIR)/$(PKG_LINUX_FIRMWARE_SUBDIR)/brcm/brcmfmac4354-sdio.bin \
> +               $(1)/lib/firmware/brcm/
> +endef

Looks much better, thanks.

Two things:
1) Do we want to include firmware for all brcmfmac supported devices?
I guess some of them are e.g. smartphones and I'm not sure if anyone
wants to run OpenWrt on them. Or should we split it into more options
maybe?
2) If we want all firmware files then for SDIO devices we could try
something clever like: $(PKG_BUILD_DIR)/brcm/brcmfmac*-sdio.bin maybe?

-- 
Rafał
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel