[OpenWrt-Devel] [PATCH] Add WeIO board (http://we-io.net) profile. This patch adds support for WeIO board, which is based on Carambola2 board from 8Devices.

[Karl Palsson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Just one more, I promise :)

Drasko DRASKOVIC <drasko.draskovic at gmail.com> wrote:
> +
> +static void __init weio_common_setup(void)
> +{
> +	u8 *art = (u8 *) KSEG1ADDR(0x1fff0000);
> +
> +	ath79_register_m25p80(NULL);
> +	ath79_register_wmac(art + WEIO_CALDATA_OFFSET,
> +			    art + WEIO_WMAC_MAC_OFFSET);
> +
> +    /** WeIO uses only WiFi by default (no ETH). If ETH jack is soldered, uncomment following lines  */
> +#if 0
> +	ath79_setup_ar933x_phy4_switch(true, true);
> +
> +	ath79_init_mac(ath79_eth0_data.mac_addr, art + WEIO_MAC0_OFFSET, 0);
> +	ath79_init_mac(ath79_eth1_data.mac_addr, art + WEIO_MAC1_OFFSET, 0);
> +
> +	ath79_register_mdio(0, 0x0);
> +
> +	/* LAN ports */
> +	ath79_register_eth(1);
> +
> +	/* WAN port */
> +	ath79_register_eth(0);
> +#endif /** commented out ETH */
> +}
> +


I still think this #ifdefed code should be removed.  None of the product
literature on your site shows any way of this being added.  It's not
like there is a two port ethernet footprint that's simply not mounted,
you'd have to connect it to the breadboard headers on the side of the
board, by the time someone's done that, it's not really the weio board
anymore is it?

Cheers,
Karl P

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJVtZMXAAoJEBmotQ/U1cr2G6gQALxTf1xexyD9kGcjNDT21HCb
t2SjZEPVBEcIYe1RUShCRdAyUs3sgDNPXHoGO9W5i/XjgX0fUxn905hQnVubBRF8
CoOfaJbxoum0RYTF9cqXeGyQVPULGTYl79yQLJqNmnoBuXkDOSQ+dkFH9lcOcTVO
4pFYSD2tt1BX8IXokET/47kMkosYK0adkjzJvppG1EXvOaRUbeM9CVlyaN+BRih5
W0oFCLEnXQdlMCj8AmIMKkohZpBj69V9yXHZVYtRuKbLcJvG3CMAIp6DRqG/Z0YT
1dAdB5rkI86OjvDUPlpLYinFPazDJ6ibpyTWNWhZ/j7NcWU7beX1t3h6Uxfs/kbq
V8lzbx2QjreVTTceNi6zDCGCqkejVwV2qH2UIK7g4Lu5m5UiF+1ttbr8CoOxtPT+
adZrFOuVtAD8OsHyx9BKcxNvmUx+1+6YfhGw4dCrePyMfG1AxTHGv6i3yguA63Yf
7LYKA/SIwTCUJiKTdwON0VpRQwnvwSIqFTXp1iah5b8Jpxpu3a8LzjH396dOfYZ2
H3IXByuMpcHkR+sst3iqhPj9ge8O9Ssp2u59HFRYTPOt+e5MTjcQVKxIFGfNXH34
1iSVInuD3MlWfLDqAGeM8dZU3KXA+DYA3hvdarRqcePXS6MdLT6NJAZ9+p3ntw2c
WfBsXbyZhdpzmSSXjkru
=1Xp3
-----END PGP SIGNATURE-----
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel