[OpenWrt-Devel] [PATCH] Add support for WeIO board. WeIO board (http://we-io.net) is based on Carambola2 module from 8Devices, and the patch adds a separate profile.

[Drasko DRASKOVIC]

Hi Karl,

On Sun, Jul 26, 2015 at 4:41 AM, Karl Palsson <karlp at tweak.net.au> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Let me just preface this with...
>
> I am _not_ any sort of authority on code style, or any sort of
> "approved" openwrt commit police.  I'm just some person subscribed to the mailing list.  You are _absolutely_ entitled to ignore anything I say.
>
> ... Apparently that makes people happier....
>
> Anyway...

I'd like to thank you for your reviews - I tried to correct all errors
that you spotted.

Anyway, new patch related to 4.1 kernel was sent yesterday evening, so
this one is not relevant anymore

>
> Drasko DRASKOVIC <drasko.draskovic at gmail.com> wrote:
>> Hi Karl,
>>
>> >> +
>> >> +MIPS_MACHINE(ATH79_MACH_WEIO, "WEIO", "WeIO board from Drasko DRASKOVIC and Uros PETREVSKI",
>> >
>> > Really?  That's your model name?  Really?  Are you _sure_ that's what
>> > you want?
>>
>> Yes, the name of the board is WeIO.
>>
>
> #define         MIPS_MACHINE(_type, _id, _name, _setup)
>
> The ID might be "WEIO", I personally was checking whether you really
> wanted your board to be called "WeIO board from Drasko DRASKOVIC and
> Uros PETREVSKI"  You want this....
>
> root at blah:~# grep machine /proc/cpuinfo
> machine                 : WeIO board from Drasko DRASKOVIC and Uros PETREVSKI
> root at blah:~#
>
> Maybe you do, that's fine, it seems a little unusual to me, and I was
> just asking if you'd really thought about this all the way.


I know this is strange, but this is what is written on the back of the
board and looks OK for this particular product.

>> >> diff --git
>> >> a/target/linux/ar71xx/patches-3.18/610-MIPS-ath79-openwrt-machines.patch
>> >> b/target/linux/ar71xx/patches-3.18/610-MIPS-ath79-openwrt-machines.patch
>> >> index f8a561c..e8c8d5a 100644
>> >> --- a/target/linux/ar71xx/patches-3.18/610-MIPS-ath79-openwrt-machines.patch
>> >> +++ b/target/linux/ar71xx/patches-3.18/610-MIPS-ath79-openwrt-machines.patch
>> >> @@ -1,6 +1,6 @@
>> >>  --- a/arch/mips/ath79/machtypes.h
>> >>  +++ b/arch/mips/ath79/machtypes.h
>> >> -@@ -16,22 +16,191 @@
>> >> +@@ -16,22 +16,192 @@
>> >>
>> >>   enum ath79_mach_type {
>> >>       ATH79_MACH_GENERIC = 0,
>> >> @@ -25,6 +25,7 @@
>> >>  +    ATH79_MACH_BHU_BXU2000N2_A1,    /* BHU BXU2000n-2 A1 */
>> >>  +    ATH79_MACH_CAP4200AG,           /* Senao CAP4200AG */
>> >>  +    ATH79_MACH_CARAMBOLA2,          /* 8devices Carambola2 */
>> >> ++    ATH79_MACH_WEIO,                /* WeIO board */
>> >
>> >
>> > Cmon man, are you sure you attached the right patch here?
>>
>> Yes, why? I can see nothing wrong with this patch.
>>
>
> The reason I asked is that already in the earlier version it had been
> raised (by me) that this was not in alphabetical order.  Yes, there are
> out of place entried in that file, but that enum is mostly well ordered.
>  It's a good idea to keep it well ordered.   The fact that the WEIO board has a carambola2 module soldered down is irrelevant.  It can't be changed, it's not a user serviceable part, they're different boards that happen to be ar71xx.

Yes, I agree. And I tried to respect this everywhere it made sense.

BR,
Drasko
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel