[OpenWrt-Devel] [PATCH] firmware-utils mktplinkfw: print amount of exceeding bytes

[Jonathan Bennett]

My comments weren't a critique of your patch, and probably belong in a
separate thread, or even a bug report on dev.openwrt.org.

Apparently the behavior my machine is showing is not the normal or intended
behavior. On my machine (Fedora 22, but also had the issue in Fedora 21, if
I remember correctly), there is no error message printed when the image
generation fails due to being too large. Running V=s shows:

[mktplinkfw] *** error: images are too big
Makefile:2244: recipe for target 'install' failed
make[5]: [install] Error 255 (ignored)

So, the real problem is that for some reason, my system is ignoring the
make error. This is unrelated to your patch. My thinking is that it was
intended behavior, and would make sense to change it in the same patch.
Sorry about the confusion.


--Jonathan

On Mon, Jul 13, 2015 at 10:46 AM Stephan Maka <stephan at spaceboyz.net> wrote:

> Jonathan Bennett wrote:
> > Tested and seems to work as intended. However, I think the image too big
> > messages should be printed at the default verbosity.
>
> The patch doesn't change any levels.
>
> > Currently, if make fails to generate the final image, it doesn't give any
> > message to acknowledge, and appears to have succeeded, there are just
> > "mysteriously" missing files in the output directory.
>
> All the ERR() outputs are followed by return -1, causing check_options()
> and therefore the process and make to fail.
>
> Sorry if I don't see your point but I'll be happy about follow-up
> patches. :)
>
>
> Cheers,
> Stephan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150713/9fbab0a2/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel