[OpenWrt-Devel] [PATCH 3/3] ar71xx: add spi nand driver support

[Florian Fainelli]

On 10/07/15 02:54, Pan, Miaoqing wrote:
> Agree with you,  I investigated this, tried to merge two into one.  E.g.  Implement the common core for spinand,  separate  vendors related codes,  but give up finally as no device to verify mt29f:(  So I only add it to support for ath79 platform.

There are some on-going efforts to come up with proper SPI NAND support
in the MTD layer, you might want to piggy back on that effort:

http://lists.infradead.org/pipermail/linux-mtd/2015-June/059837.html

> 
> Thanks,
> Miaoqing
> 
> -----Original Message-----
> From: Jonas Gorski [mailto:jogo at openwrt.org] 
> Sent: Friday, July 10, 2015 5:44 PM
> To: Pan, Miaoqing
> Cc: OpenWrt Development List
> Subject: Re: [OpenWrt-Devel] [PATCH 3/3] ar71xx: add spi nand driver support
> 
> Hi,
> 
> On Fri, Jul 10, 2015 at 9:18 AM,  <miaoqing at qti.qualcomm.com> wrote:
>> From: Miaoqing Pan <miaoqing at codeaurora.org>
>>
>> Derived from 'drivers/staging/mt29f_spinand'.
>>
>> Only support Giga Device SPI NAND device now,
>>     - GD5F1GQ4U 1G 3.3V 8-bit
>>     - GD5F2GQ4U 2G 3.3V 8-bit
>>     - GD5F1GQ4R 1G 1.8V 8-bit
>>     - GD5F2GQ4R 2G 1.8V 8-bit
>>
>> Signed-off-by: Miaoqing Pan <miaoqing at codeaurora.org>
> 
> This looks exactly like mt29f_spinand, except with ath79_ prefixed to everything. Also I don't see anything ath79 specific in here.
> 
> Why can't you just use mt29f_spinand directly? And why do you need to create a copy of it instead of just fixing it in the driver itself?
> 
> 
> Jonas
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel