[OpenWrt-Devel] [PATCH netifd] bridge: allow enabling or disabling the multicast querier independently of IGMP snooping

[Matthias Schiffer]

On 01/28/2015 01:34 PM, John Crispin wrote:
> 
> 
> On 28/01/2015 13:30, Matthias Schiffer wrote:
>> On 01/28/2015 11:54 AM, John Crispin wrote:
>>> change this to
>>>
>>> bridge->ifname, (cfg->igmp_snoop & cfg->multicast_querier) ? "1"
>>> : "0");
>>>
>>> this should not break anything with multiple ubus calls. the
>>> default behavior also wont change as we set
>>> cfg->multicast_querier = true;
>>>
>>> Please make those changes to the patch and resend it.
>> Wouldn't it be better to change the possible values of
>> multicast_querier to "yes", "no" and "unset"? That way it could
>> always default to the igmp_snoop value when it is unset, but it
>> would be possible to override it in both ways.
>>
> 
> do you call this by hand or via webui/rpc ?
At the moment, this is compile-tested only. My only usecase is setting
it in /etc/config/network.

Your suggestion would make it impossible to enable the multicast querier
without also enabling snooping. My intention was to allow all four
combinations of snooping on/off and querier on/off, while having the
querier setting default to the snooping setting (so nothing changes for
people who have set igmp_snoop, but not multicast_querier). While I
don't need the case "querier on/snooping off", I don't see why we
shouldn't allow it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150128/58727837/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel