[OpenWrt-Devel] [PATCH] list: remove double freeing of section

[Felix Fietkau]

On 2015-01-06 08:23, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists at googlemail.com>
> 
> This error was reported by cppcheck. Compile tested only.
> 
> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
> ---
>  list.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/list.c b/list.c
> index 0d00f81..46f8943 100644
> --- a/list.c
> +++ b/list.c
> @@ -346,7 +346,6 @@ uci_lookup_ext_section(struct uci_context *ctx, struct uci_ptr *ptr)
>  	goto done;
>  
>  error:
> -	free(section);
>  	memset(ptr, 0, sizeof(struct uci_ptr));
>  	UCI_THROW(ctx, UCI_ERR_INVAL);
False positive - the "done" part is never reached due to the UCI_THROW call.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel