[OpenWrt-Devel] [PATCH v2 2/2] dnsmasq: fix dependency problems of the dnsmasq-full variant.

[Frank Schäfer]

Am 04.01.2015 um 12:22 schrieb Yousong Zhou:
>>>>> diff --git a/package/network/services/dnsmasq/patches/200-let-makefile-be-aware-of-config-changes.patch b/package/network/services/dnsmasq/patches/200-let-makefile-be-aware-of-config-changes.patch
>>>>> new file mode 100644
>>>>> index 0000000..663f0e9
>>>>> --- /dev/null
>>>>> +++ b/package/network/services/dnsmasq/patches/200-let-makefile-be-aware-of-config-changes.patch
>>>>> @@ -0,0 +1,42 @@
>>>>> +Index: dnsmasq-2.72/Makefile
>>>>> +===================================================================
>>>>> +--- dnsmasq-2.72.orig/Makefile       2014-12-30 19:46:10.484921940 +0800
>>>>> ++++ dnsmasq-2.72/Makefile    2014-12-30 19:56:39.712926794 +0800
>>>>> +@@ -74,6 +74,10 @@
>>> <snip>
>>>
>>>> Urgh... is it really necessary to patch dnsmasqs native Makefile ?
>>>> Can you give us a practical and reproducable example that shows the
>>>> problem you are trying to solve here ?
>>> Patching Makefile of dnsmasq itself is necessary for the build system
>>> of OpenWrt and Makefile of dnsmasq to pick up a possibly updated
>>> config of dnsmasq-full variant.  Otherwise rebuild of dnsmasq-ful may
>>> not happen as expected when users enable or disable a feature with
>>> e.g. make menuconfig.
>> Ok, I can reproduce it now...
>> Is this patch suitable for upstream inclusion ?
>>
> An fixed up version of this patch is already in upstream dnsmasq now.

Excellent, thanks !

> But another one has to be applied to fix possible race condition from
> happening when doing parallel build.  I am truly sorry but it seems
> like there are just too many cases to be tested out in each iteration.
>
> [1] http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2015q1/009068.html

Anything I can do to help ?
Which cases need to be tested ?

Regards,
Frank


> Regards.
>
>                yousong
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel