[OpenWrt-Devel] [PATCH v2] kernel: Fix USB gadget modules for v3.18

[Daniel Golle]

Hi!

that looks much better already. Thanks for taking care of that.
(though many were aware of the problem, none were willing to fix
it for now, including myself)

On Thu, Feb 19, 2015 at 02:41:57PM -0800, Owen Kirby wrote:
> ...
> +ifeq ($(CONFIG_LINUX_3_8)$(CONFIG_LINUX_3_10),)

Note that there are (unfortunately) still targets stuck on 3.3.
I doubt that this is relevant, but as that whole legacy section
can most likely be removed in the near future, I reckon it doesn't
hurt to add it for now.
Probably it makes more sense to simply add a dependency
DEPENDS:=@!LINUX_3_3 @!LINUX_3_8 @!LINUX_3_10
for all usb-gadget packages instead of creating an empty package
for these kernels (unless this is intended e.g. in case of the
driver having to be built-in or something like that)

> -  FILES:=$(LINUX_DIR)/drivers/usb/gadget/g_ether.ko
> +  FILES:= $(LINUX_DIR)/drivers/usb/gadget/g_ether.ko

No need to add a space here.

> ...
> +ifeq ($(CONFIG_LINUX_3_8),)

Maybe include 3.3 here as well... (or add a dependency instead).

> ...
>  else
> -  FILES:=$(LINUX_DIR)/drivers/usb/gadget/g_serial.ko
> +  FILES:= $(LINUX_DIR)/drivers/usb/gadget/g_serial.ko

Another unneeded space.



Cheers


Daniel
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel