[OpenWrt-Devel] [PATCH] kernel: generic 4.1 & 4.4 perf: musl compatibility

[Kevin Darbyshire-Bryant]

On 29/12/15 11:13, Hauke Mehrtens wrote:
>
> On 12/29/2015 11:14 AM, Kevin Darbyshire-Bryant wrote:
>> Enable linux perf tools to compile under musl.
>>
>> Tested on MIPS Archer c7 v2 & ARM Linksys 1200ac.
>>
>> With thanks to Dave Taht <dave.taht at bufferbloat.net> who
>> did the heavy lifting.
>>
>> Signed-off-by: Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk>
>> ---
>>  package/devel/perf/Makefile                        |   2 +-
>>  .../patches-4.1/280-perf-fixes-for-musl.patch      | 148 +++++++++++++++++++++
>>  .../patches-4.4/280-perf-fixes-for-musl.patch      | 147 ++++++++++++++++++++
>>  3 files changed, 296 insertions(+), 1 deletion(-)
>>  create mode 100644 target/linux/generic/patches-4.1/280-perf-fixes-for-musl.patch
>>  create mode 100644 target/linux/generic/patches-4.4/280-perf-fixes-for-musl.patch
>>
>> diff --git a/package/devel/perf/Makefile b/package/devel/perf/Makefile
>> index 5e3d63f..46ddb92 100644
>> --- a/package/devel/perf/Makefile
>> +++ b/package/devel/perf/Makefile
>> @@ -19,7 +19,7 @@ include $(INCLUDE_DIR)/package.mk
>>  define Package/perf
>>    SECTION:=devel
>>    CATEGORY:=Development
>> -  DEPENDS:= @USE_GLIBC +libelf1 +libdw +libpthread +librt +binutils
>> +  DEPENDS:= @USE_MUSL +libelf1 +libdw +libpthread +librt +binutils
Hi Hauke,

Let me prefix this with "I don't know what I'm doing"
> Does it not work with GLIBC any more or why do you make it depend on
> musl only now? Does this work with uclibc-ng?
I suspect it'll break spectacularly with glibc.  I'm sure the patches
could be modified to have both glibc & musl compatibility but it's
beyond my wit to know how.  I was interested in getting perf to work
(without enabling broken packages) under Archer C7 v2 which uses musl
now by default.  I've no idea about uclibc-ng.
>
> I assume that this will not work on kernel 3.18 and kernel 4.3, which is
> fine, as you haven't added patches for these kernel versions, but the
> dependency is missing. Please add @!LINUX_3_18 @!LINUX_4_3
Now that's something I can do....if it's worth the bother bearing in
mind other comments?
>
> Will this be in kernel 4.5?
No idea.  My Archer (ar71xx) isn't on 4.4 yet let alone 4.5


A few people have put effort into getting perf running on the above
mentioned platforms, I thought it worth throwing at OpenWrt devel list
as a patch to pass the effort on and see what sticks :-)  If it doesn't
stick then fair enough.

Kevin


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4816 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20151229/8284f527/attachment.p7s>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel