[OpenWrt-Devel] [PATCH][RFC] kernel: swconfig: add API for setting port link speed

[Rafał Miłecki]

On 13 December 2015 at 13:40, Stefan Rompf <stefan at loplof.de> wrote:
>>       int (*get_port_link)(struct switch_dev *dev, int port,
>>                            struct switch_port_link *link);
>> +     int (*set_port_link)(struct switch_dev *dev, int port,
>> +                          enum switch_port_speed speed);
>
> this creates an assymetric API. I think the prototype of the set function
> should be
>
> int (*set_port_link)(struct switch_dev *dev, int port,
>                      struct switch_port_link *link);
>
> to allow setting other parameters that are part of struct switch_port_link,
> like duplex or flow control. I'd be rather happy to disable crappy ethernet
> flow control on my router...

Thanks, I'll work on this.

For the future: it's preferred to reply to the latest patch version.
Your comment isn't visible for the V1 in patchwork:
https://patchwork.ozlabs.org/patch/556017/

-- 
Rafał
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel